search

ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup
https://autoxtrabackup.azepug.az/
MIT License
140 stars 79 forks source link

tar.gz files not cleaned from archive dir #345

Closed gitmstoute closed 4 years ago

gitmstoute commented 5 years ago

When running with archive_dir set & move_archive = 0, autoxtrabackup places tar.gz files in the archive_dir. The tar.gz files are not removed during cleanup, so the archive_max_duration and archive_max_size configs are effectively ignored.

I will send a PR soon.

ShahriyarR commented 5 years ago

Great. Waiting for your PR. Thanks.

gitmstoute commented 5 years ago

submitted PR #346

BarbzYHOOL commented 5 years ago

Trivial fact: you should keep the issue open until it's merged and in your PR add "Closes https://github.com/ShahriyarR/MySQL-AutoXtraBackup/issues/345" so it will close it automatically :)

gitmstoute commented 5 years ago

Thanks @BarbzYHOOL ! I actually thought I did something wrong; Is it possible to submit a PR with the same ID (345) so it's automatically linked to this issue? I thought I had effectively accidentally duplicated my own issue with my PR.

gitmstoute commented 5 years ago

Thanks @BarbzYHOOL ! I actually thought I did something wrong; Is it possible to submit a PR with the same ID (345) so it's automatically linked to this issue? I thought I had effectively accidentally duplicated my own issue with my PR.

I did a bit more reading so I understand it better - however I'm not sure where exactly to put "closes 345".

BarbzYHOOL commented 5 years ago

Anywhere ^^ (i found this by hazard though)

ShahriyarR commented 5 years ago

@gitmstoute If you want to fix and close issue during merge process.