search

ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup
https://autoxtrabackup.azepug.az/
MIT License
141 stars 78 forks source link

Bugfix issue345 #346

Closed gitmstoute closed 5 years ago

gitmstoute commented 5 years ago

Main component to this fix is generalops.py was checking for max_archive_size in BCK, but then trying to assign archive_max_size (instead of what it checked for: max_archive_size). So, the variables were never being set properly.

archivemax[size/duration] seems like the preferred variable names so I cleaned that up a bit throughout the project.

closes 345

ShahriyarR commented 5 years ago

Thank you for PR. I am going to create release_v1.5.5 branch and merge your changes there.

ShahriyarR commented 5 years ago

Also there is a nice Feature Request: https://github.com/ShahriyarR/MySQL-AutoXtraBackup/issues/307

Maybe you can implement it also if you have some passion further :)