search

ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup
https://autoxtrabackup.azepug.az/
MIT License
140 stars 79 forks source link

Feature 307 #348

Closed gitmstoute closed 5 years ago

gitmstoute commented 5 years ago

@ShahriyarR I believe this will close 307.

I haven't gotten your tests set up yet, So I haven't done any automated testing... We should be careful because it's possible I made some errors.

I was trying to drop some of these unnecessary commits (233f772, 3d8b995 in particular), and squash or clean up others, but couldn't quite get it.

gitmstoute commented 5 years ago

@ShahriyarR It is not needed there - that's what I meant about trying to clean up some commits, but I wasn't confident with git. I believe 233f772 creates the conf file, 3d8b995 deletes it again. I was trying to remove these two commits.

gitmstoute commented 5 years ago

@ShahriyarR I can take some time to try again and clean up the commits

ShahriyarR commented 5 years ago

@gitmstoute It would be great. if you can explain what kind of changes you did, that can be helpful also. Just few explanations can help me with my tests.

gitmstoute commented 5 years ago

I'll resubmit a different PR

BarbzYHOOL commented 5 years ago

Note: shahriyarR can squash all your commits into one when merging, for a clean history