search

ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup
https://autoxtrabackup.azepug.az/
MIT License
139 stars 79 forks source link

Fix some errors #365

Closed dakine1111 closed 4 years ago

dakine1111 commented 4 years ago

There is no python mysql-connector package anymore, it's now called mysql-connector-python. Password should always be used with quotation marks.

BarbzYHOOL commented 4 years ago

@shahriyarR seems like it can't hurt :P just notifying you

ShahriyarR commented 4 years ago

It seems to be yes there is no harm :) But nowadays I am at least trying to pursue MSc Robotics - especially struggling with Kalman Filters and Machine Learning. So I am partially available in this life, please excuse me If I am going to act here as late as hell :D

BarbzYHOOL commented 4 years ago

ok good luck ! you could just merge it though if it's small modif like that

BarbzYHOOL commented 4 years ago

@dakine1111 is this issue https://github.com/ShahriyarR/MySQL-AutoXtraBackup/issues/366 related ??

dakine1111 commented 4 years ago

Yes, my pull request should fix this.

BarbzYHOOL commented 4 years ago

alright thank you guys

however, I just saw that there is "mysql-connector" 2.2.9 for python 3, this is weird no? which one is correct then?

and here https://mysql-autoxtrabackup.readthedocs.io/en/latest/installation.html it was already written mysql-connector-python, weird again

BarbzYHOOL commented 4 years ago

Could not find a version that satisfies the requirement mysql-connector-python==2.1.4 (from mysql-autoxtrabackup==1.5.2) (from versions: 8.0.5, 8.0.6, 8.0.11, 8.0.12, 8.0.13, 8.0.14, 8.0.15, 8.0.16, 8.0.17, 8.0.18)

so let's just change to 8.0.5? or is it a bad idea