Closed ShahriyarR closed 4 years ago
✅ Merging this PR will increase code quality in the affected files by 0.03 out of 10.
Before | After | Change | |
---|---|---|---|
Quality | 8.01 | 8.04 | 0.03 |
Complexity | 3.88 | 3.05 | -0.83 |
Method Length | 72.37 | 74.08 | 1.7 |
Lines | 707 | 700 | -7 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
init.py | 9.73 | N/A | N/A |
setup.py | 8.09 | 8.07 | -0.02 ⬇️ |
backup_backup/init.py | 9.93 | N/A | N/A |
backup_backup/backup_archive.py | N/A | 6.76 | N/A |
backup_backup/backup_builder.py | N/A | 7.8 | N/A |
backup_backup/backuper.py | 7.24 | 7.87 | 0.63 ⬆️ |
general_conf/generalops.py | 8.56 | 8.52 | -0.05 ⬇️ |
utils/mysql_cli.py | 8.93 | 9.08 | 0.16 ⬆️ |
Here are some functions in these files that still need a tune-up:
File | Function | Quality | Recommendation |
---|---|---|---|
backup_backup/backup_archive.py | BackupArchive.create_backup_archives | 3.13 | Split out functionality |
backup_backup/backuper.py | Backup.all_backup | 5.13 | Split out functionality |
backup_backup/backup_builder.py | BackupBuilderChecker.general_command_builder | 5.36 | Split out functionality |
backup_backup/backup_builder.py | BackupBuilderChecker.extract_decrypt_from_stream_backup | 5.85 | Split out functionality |
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
I think it is enough for this issue. Going further with Prepare class refactoring.
Decided to fix GeneralClass composition issues on this branch + code refactoring on the fly