Closed ShahriyarR closed 4 years ago
✅ Merging this PR will increase code quality in the affected files by 0.18 out of 10.
Before | After | Change | |
---|---|---|---|
Quality | 8.11 | 8.29 | 0.18 |
Complexity | 3.62 | 2.75 | -0.87 |
Method Length | 66.87 | 63.65 | -3.22 |
Lines | 733 | 796 | 63 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
backup_backup/backuper.py | 7.87 | 7.87 | 0.0 |
backup_prepare/copy_back.py | N/A | 8.78 | N/A |
backup_prepare/prepare.py | 8.03 | 6.17 | -1.85 ⬇️ |
backup_prepare/prepare_builder.py | N/A | 8.21 | N/A |
general_conf/generalops.py | 8.52 | 8.51 | -0.01 ⬇️ |
process_runner/errors.py | N/A | 9.6 | N/A |
Here are some functions in these files that still need a tune-up:
File | Function | Quality | Recommendation |
---|---|---|---|
backup_prepare/prepare.py | Prepare.prepare_with_tags | 3.09 | Split out functionality |
backup_prepare/prepare.py | Prepare.prepare_inc_full_backups | 4.81 | Split out functionality |
backup_backup/backuper.py | Backup.all_backup | 5.13 | Split out functionality |
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Fixed #412