Open JasperAlgra opened 3 years ago
JasperAlgra
commented
3 years ago Also, I've had similar issues before in 1.5.x.
Maybe to circum/prevent this issue there could be a --generate-config-file option or so?
Or a config file template on github instead of the lines in generate_default_conf.py which are a bit of a pain to copy paste by hand to a new config file.
ShahriyarR
commented
3 years ago Hmm why I missed this issue? :D Okay I am going to create an option for generating the config file and also the config file template. Thanks guys)
JasperAlgra
commented
3 years ago Hi @ShahriyarR ,
After this merge I've got this:
root@dev:/home/jasper/autoxtrabackup# python3 mysql_autoxtrabackup/autoxtrabackup.py --generate-config-file
Missing config file : /root/.autoxtrabackup/autoxtrabackup.cnf
Traceback (most recent call last):
File "mysql_autoxtrabackup/autoxtrabackup.py", line 321, in <module>
all_procedure()
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1062, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 763, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/click/decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "mysql_autoxtrabackup/autoxtrabackup.py", line 203, in all_procedure
logging_options = options.logging_options
File "/root/.local/lib/python3.7/site-packages/mysql_autoxtrabackup/general_conf/generalops.py", line 42, in logging_options
"log_level": self.con.get(section, "log"),
AttributeError: 'GeneralClass' object has no attribute 'con'I'm not really sure what's causing this. Looks like autoxtrabackup.py: 208 tries to get the logging options from generalops.py:42 which tries to get it from the config file.. but that one doesn't exist.
ShahriyarR
commented
3 years ago @JasperAlgra This project is can be shown as a study case of what happens - "when you have no tests" :D I will take a look )
JasperAlgra
commented
3 years ago Thanks a lot man! What is your plan with this project? Are you planning to continue to use it yourself in production ?
I've got a taste from the mongodb backup with PointInTime recovery and fully managed + verified backups, which is very very nice... but it seems we will continue to use Percona xtraDB cluster in production instead of the planned mongo. So I'm also willing to donate some time to this project as it's valuable for us. But Pyhton is very-much not my language so I'm struggling a bit to contribute in a efficient way :')
I really like your idea of the new API. It would be a nice way to verify if/when backups are made by a monitoring tool and get alerting etc.
Hi,
When installing the new v.2 (awesome by the way!) the config dir ~/.autoxtrabackup and config files are not created. Host: Debian 10. Command:
as root. Result of install:
The dir ~/.autoxtrabackup and config files are not created. I'm not sufficient enough in Python to quickly see why the
__init__.pyfromgeneral_confisn't doing it's job. I've cleared the pip cache, same result. I've also tried building from source, please see log all the way down.Thus autoxtrabackup is not working:
If I can provide more info please let me now
Building from source log: