search

ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup
https://autoxtrabackup.azepug.az/
MIT License
141 stars 79 forks source link

bugfix: ValueError: could not convert string to float: 'None' #449

Closed ShahriyarR closed 3 years ago

ShahriyarR commented 3 years ago

The wrong config option was used and it fails when the tool tries to use backup archive feature.

Now it will raise BackupArchiveNotConfigured error if options were not set and also it will check for archive_max_duration

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.31%.

Quality metrics Before After Change
Complexity 13.60 🙂 13.52 🙂 -0.08 👍
Method Length 70.50 🙂 69.71 🙂 -0.79 👍
Working memory 16.67 ⛔ 16.40 ⛔ -0.27 👍
Quality 55.35% 🙂 55.66% 🙂 0.31% 👍
Other metrics Before After Change
Lines 616 631 15
Changed files Quality Before Quality After Quality Change
mysql_autoxtrabackup/autoxtrabackup.py 45.55% 😞 45.55% 😞 0.00%
mysql_autoxtrabackup/backup_backup/backup_archive.py 41.62% 😞 40.58% 😞 -1.04% 👎
mysql_autoxtrabackup/general_conf/generalops.py 81.02% ⭐ 81.02% ⭐ 0.00%
mysql_autoxtrabackup/process_runner/errors.py 96.04% ⭐ 95.95% ⭐ -0.09% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
mysql_autoxtrabackup/autoxtrabackup.py all_procedure 27 😞 619 ⛔ 46 ⛔ 11.23% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
mysql_autoxtrabackup/backup_backup/backup_archive.py BackupArchive.create_backup_archives 30 😞 256 ⛔ 11 😞 29.21% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
mysql_autoxtrabackup/backup_backup/backup_archive.py BackupArchive.clean_old_archives 15 🙂 169 😞 12 😞 43.33% 😞 Try splitting into smaller methods. Extract out complex expressions
mysql_autoxtrabackup/general_conf/generalops.py GeneralClass.backup_archive_options 4 ⭐ 126 😞 7 🙂 68.28% 🙂 Try splitting into smaller methods
mysql_autoxtrabackup/general_conf/generalops.py GeneralClass.backup_options 0 ⭐ 126 😞 5 ⭐ 77.29% ⭐ Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!