ShahriyarR / one-time-secret-share

One time secret sharing service on top of ReadOnce objects
MIT License
21 stars 5 forks source link

Minor improvment in README.md #30

Closed sevdimali closed 1 year ago

sevdimali commented 1 year ago

Description of changes

How to test?

ShahriyarR commented 1 year ago

Thanks for the PR.

The migrations were intentionally abandoned. As we have no admin panel or database tables to work with, there is no need for built-in table migrations. Only while running the tests, the Django TestCase will create test tables, which should be dropped after test completion.

sevdimali commented 1 year ago

Thanks for the PR.

The migrations were intentionally abandoned. As we have no admin panel or database tables to work with, there is no need for built-in table migrations. Only while running the tests, the Django TestCase will create test tables, which should be dropped after test completion.

@ShahriyarR

image
ShahriyarR commented 1 year ago

@sevdimali Interesting.

For local testing and to make it close to production setup I use the following commands:

First fire up the gunicorn:

make run

Second enable https over ngrok:

ngrok HTTP 8000

And that's it. Basically, it should work locally as well. I am not sure why it tries to access the Django session.

sevdimali commented 1 year ago

I didn't get the error while browsing in incognito mode. I think the problem is, I accessed the local development server from the HTTP and in regular browsing mode, the session cookie will not be sent by the browser(SESSION_COOKIE_SECURE = True). As a result, Django tries to create it in the database and throws the no such table: django_session error. I am not 100% sure about it 😬

ShahriyarR commented 1 year ago

:D Interesting consequences of forcing cookie usage) thanks for giving feedback.

ShahriyarR commented 1 year ago

If you are still interested in the README update, please update PR eliminating the migration changes. Then we can merge it. Also if you could spot any other issues please report them as well) Thanks.