Shakz76 / Eazy-Hax-RetroPie-Toolkit

A toolkit for fixing common issues and enabling features on your RetroPie
GNU Affero General Public License v3.0
59 stars 5 forks source link

Background music does not stop during games #10

Open KTac opened 5 years ago

KTac commented 5 years ago

Thank you for this excellent toolkit. I am running a freshly installed and fully up to date image of RetroPie and when I set up this script the music will not stop when I start a game. I'm using RetroArch for everything and line 25 of my script looks as it should with retroarch listed as the first item in emulatornames. I started over from a clean install once already just to make sure I didn't mess anything up. My gut is telling me it's something in a recent update to RetroPie that's causing this.

SlowCatalyst commented 5 years ago

Made an account just to reply to this.

Ok- so first off, I've tried this between a Pi 3B+, Pi Zero W, FreePlay Zero Kits, and FreePlay CM3/+ kits [I'm a contracted builder of Pi systems for people].

It looks like there were a few versions of EmulationStation along the way since this Toolkit was last updated, that did not play nice with the music playback.

What I've found as of last weekend, is that after updating all packages and kernel via the RetroPie Setup menu after a fresh SD imaging of RetroPie, and THEN installing the toolkit- toggling the music, and auto start/stop is working again in between emulators.

Just remember though- the music will not pause for non-"lr" emulators, which is where the toggle is handy before and after an emulator like say, DraStic or non-lr Dgen.

That's about the only consistency I can find. It didn't work for many ES releases, but seems to be working again, and doesn't look like it was due to the toolkit being updated. I'm not 100% sure why it's working for me now other than that I'm on a current ES that seems to play nice with it again. But remember- fresh image. Do all updates. Restart. Install toolkit. Boot back up. Install BG music. Restart. Boot back up. Pray.

KTac commented 5 years ago

@SlowCatalyst thanks for this information.

What I've found as of last weekend, is that after updating all packages and kernel via the RetroPie Setup menu after a fresh SD imaging of RetroPie, and THEN installing the toolkit- toggling the music, and auto start/stop is working again in between emulators.

I guess I did things slightly out of order. I installed the toolkit first, then updated RetroPie. Even if I started over and did things in the order you found to work, doesn't this likely indicate that it will break the next time I update RetroPie?

Just remember though- the music will not pause for non-"lr" emulators, which is where the toggle is handy before and after an emulator like say, DraStic or non-lr Dgen.

Isn't that the purpose of the "emulatornames" array created on line 25 of .livewire.py, to provide a list of names of the executables used in RetroPie so that the music will be paused and resumed for all emulators? Drastic and DGen are listed there by default along with RetroArch and many others. Are you saying that with this method you've found it only works now for RetroArch?

SlowCatalyst commented 5 years ago

"Just remember though- the music will not pause for non-"lr" emulators, which is where the toggle is handy before and after an emulator like say, DraStic or non-lr Dgen."

100% ignore this bit. Went full Freudian and confused this for a complete other function I've got in place on these systems. LiveWire will definitely halt and resume/acknowledge the non-lr's. Was messing with pisnes on a Zero, realized music stopped, and came right back to correct this small bit of mis-info, lol.

SlowCatalyst commented 5 years ago

"Even if I started over and did things in the order you found to work, doesn't this likely indicate that it will break the next time I update RetroPie?"

That would seem to be the case. I suppose the LiveWire/Toolkit scripts need to be maintained around any kernel changes that are made with heavy updates. To what degree- I have no clue. That's about where my expertise ends, haha. I'm merely connecting dots on a whiteboard at this point.

KTac commented 5 years ago

Thanks for the reply. It seems like having background music may be more trouble than it's worth with this method if it's subject to break unexpectedly with RetroPie updates. I may look into another solution for background music.

SlowCatalyst commented 5 years ago

Just now noticed this- I guess it pays to read what the author has to say, lol. D'oh!

Opening paragraph on this Toolkit:

"Due to changes that the team at RetroPie and Raspberry Pi have made to the OS the scripts require regular maintenance to function reliably....so update your scripts often or make sure you subscribe to my channel and enable notifications so you don't miss out!"

Welp. There ya' have it.