ShalmonAnandas / Gui-Youtube-dl

A cross platform GUI for youtube-dl written entirely in python using the WX library.
GNU General Public License v3.0
100 stars 10 forks source link

Unhandled Exception, Weird Cookie Discrepancies, Can't Download Video from Void.gg #15

Open ZaCloud opened 8 months ago

ZaCloud commented 8 months ago

HI again. Maybe this is partially just a case of this program not being able to parse the information on void.gg?

But a lot of the other error messages are weird, & once again some of the files in this package seem to have an identity crisis.

From the menu I managed to get (from gui_rework.exe, since the other one won't stay open long enough to figure it out), I clicked on "Single Video". _For some reason, the Cookie field defaulted to "batchfile.txt". I would've thought it should select "default_cookies.txt", & would instead use "batch_file" for the Multiple Videos section... but I left it alone & put in the URL I wanted to extract a video from: https://void.gg/post/12848

After selecting desired quality (1080p) & destination, I clicked the Download button. A black window popped up, blank for a while, then suddenly a bunch of text spewed out & it disappeared before I could read it.

(Really not user-friendly... I ended up having to use OBS to record myself doing this stuff, pause at just the right time, & take screenshots of the video. :( This could really use a fix in & of itself.)

It said what's in this screenshot (sorry, I have to type so much already I can't transcribe all this stuff too)

vlcsnap-2024-03-14-16h12m16s406

I understand if the "unsupported URL" simply means this program can't parse how Void handles their videos, though I hope that can be updated...

But I'm reporting this because it also said permission denied, related to the cookies, then failing to execute the script due to unhandled exception. Is that an error of the program that might need fixed?


So then, I figured I should try again, but with the cookies that I think seem to actually be meant for single video downloads, "default_cookies.txt", & tried again. Once again, a black window flashed up, sat a moment, then vomited error text again before promptly vanishing. Again, I recorded & exported a screenshot of the single frame with the full message:

vlcsnap-2024-03-14-16h19m16s304

And hooooo boy, that's REALLY confusing! It says the cookies' directory isn't a valid URL or something, then tells me I should use the same directory that it said was invalid (I dunno how to even do that!), the directory string has the "default_cookies.txt" as being under "multi_download_files", even though I was using the "Single Video Download" submenu, & ALSO has an incomplete folder address in there (C:\Program)....? (Does it not like there being a space between the words "Program Files" or something?)


Actually looking in the program folder, I guess for some reason all the "cookies" are just dumped in the "multi_download_files" folder (why not just call it Cookies then?), & they're ALL totally blank except the "default" one which says:

# Netscape HTTP Cookie File
# This file is generated by yt-dlp.  Do not edit.

Upon further testing I WAS able to download a YouTube video, with "default_cookies.txt" (though it seems unable to handle Shorts, & I guess I had to have the ffmpeg version of this program to get the video/audio merged. I wish that was made more clear on the Readme or Release page cuz I didn't know that's what it was for & thought it would do that by default). It still had the same error as my second screenshot at the very beginning of the status screen, fussing about the cookies, & 10 or so other Warnings, but it worked.

Like... I know I'm a tech noob, but it kind of looks like this program's got so many internal & external inconsistencies that it doesn't know what's where... ^^;; But of course if it's my fault somehow, or only caused by trying to download from Void.gg, please let me know.

But if not, uh, I hope this can be looked into too. Thanks.

ShalmonAnandas commented 8 months ago

Apologies for the extremely inconsistent flow of the app. This was the first app I ever made and it is far from perfect, actually far from usable right now I'd say, since it hasn't been updated for 2 years. I'm planning to work on a remake of the app since the code is so bad, its borderline unmaintainable. Will post a link to that repo and archive this once it is in an alpha state. Hope to have your feedback there as well. Cheers!