Validate mcmcTab ROPE input

ShanaScogin / BayesPostEst

An R package to generate and plot postestimation quantities after estimating Bayesian regression models using MCMC

https://shanascogin.github.io/BayesPostEst/

GNU General Public License v3.0

12 stars 2 forks source link

Validate mcmcTab ROPE input #44

Closed andybega closed 5 years ago

andybega commented 5 years ago

The current code seems to work no matter what the ROPE input is:

mcmcTab(fit, ROPE = "a")

produces:

  Variable Median    SD  Lower Upper PrOutROPE
1     b[1]  0.108 0.090 -0.066 0.285         1
2     b[2]  0.527 0.166  0.197 0.837         1
3     b[3]  0.636 0.161  0.328 0.948         1

jkarreth commented 5 years ago

Thank you for catching this! I'll look into it - perhaps as straightforward as adding a warning if the input to ROPE is not a vector of 2 numeric values.

andybega commented 5 years ago

Hello, this is fixed in one of the commits (https://github.com/andybega/BayesPostEst/commit/1a7b54d5e72fc31caef699e2b6d8170e0dd9acac) in my pull request (#46).

jkarreth commented 5 years ago

Fantastic! Thank you. @ShanaScogin , can you close this once Andy's pull request (#46 ) is merged with master?

ShanaScogin commented 5 years ago

Done and done!