ShaneBeeStudios / McDeob

Re-mapping and deobfuscation tool for Minecraft
Apache License 2.0
178 stars 16 forks source link

package-info files are not decompiled correctly #18

Closed DalekCraft2 closed 2 years ago

DalekCraft2 commented 2 years ago

Package info files are supposed to have annotations above the package line, and then imports, and then the file ends. However, the decompiled java files instead have the annotations above an interface package-info {} line, which does not compile anyway due to the package part of the interface's name being recognized as a keyword. Below is an example of what I mean.

Expected:

@ParametersAreNonnullByDefault
package foo.bar;

import javax.annotation.ParametersAreNonnullByDefault;

Got:

package foo.bar;

import javax.annotation.ParametersAreNonnullByDefault;

// $FF: synthetic class
@ParametersAreNonnullByDefault
interface package-info {
}
ShaneBeee commented 2 years ago

as with #22 I did not write the decompiler. Please see that issue if you wish to report issues with the decompiler.