search

ShaneBeeStudios / McDeob

Re-mapping and deobfuscation tool for Minecraft
Apache License 2.0
178 stars 16 forks source link

[Linux] Bug when remapping/decompiling both client and server #3

Closed BenCat07 closed 3 years ago

BenCat07 commented 3 years ago

Not sure if this is linux only, but if you decompile/remap client first, and then try to do server aswell without restarting the program, it doesn't remap/decompile the server, it just downloads the jar and assumes it is done.

BenCat07 commented 3 years ago

i assume this happens because some variables do not get reset on hitting the button

ShaneBeee commented 3 years ago

i assume this happens because some variables do not get reset on hitting the button

Thats probably a safe bet. I most likely made the assumption a user was not going to run the app twice. Ill do some testing tomorrow, and if I find the issue I will fix it up.

BenCat07 commented 3 years ago

Thanks for the quick reply, currently using your program to figure out how firework damage is calculated exactly :P

ShaneBeee commented 3 years ago

Ok I did some testing, and I can confirm, when going from client -> server, it just stops after downloading

Screen Shot 2020-12-17 at 1 42 19 PM

I will do my best to get this bug sorted out.

ShaneBeee commented 3 years ago

Ok, so turns out the issue was with the remapper I am using (Reconstruct), it has a static list of Transformers, which has no way of clearing, so if the program is run more than once, it failed to re-register the transformer.

I have a fork of Reconstruct (because I had to change the logger), so I just added a method to clear the transformers.

ShaneBeee commented 3 years ago

Ok, fixed and released: https://github.com/ShaneBeeStudios/McDeob/releases/tag/2.1.24