ShaneBeee / EnchBook

GNU General Public License v3.0
3 stars 1 forks source link

Possible issue enchanting items with books #10

Open Foxshot21 opened 1 year ago

Foxshot21 commented 1 year ago

hello im not sure the intended outcome here but the issue i am having is i want to be able to allow players to add max protection books to the gear they want. ex prot 4, projectile prot 4, fire prot 4, blast prot 4 in the anvil is this supported via this plugin or is this just not functioning ? if not would you be willing to add support for this ?

ShaneBeee commented 1 year ago

is this not vanilla behaviour?

Foxshot21 commented 1 year ago

yes it is vanilla behavior .this is why i am asking if it is supported as unsafe enchants are enabled and as such would this allow the unsafe enchant to be added for vanilla behavior i would just not use a plugin

ShaneBeee commented 1 year ago

I think Im confused what you are asking here. The plugin is not allowing you to add vanilla enchantments to the item?

i am asking if it is supported as unsafe enchants are enabled

There is no config option for "unsafe enchants" There is an option for "safe enchants", which when disabled allows enchanting over the max level.

If you could elaborate in more detail what your actual issue is, it will help me better understand what you want. At this point, with the information you have provided, I'm not really sure what you are asking for.

Foxshot21 commented 1 year ago

ok so for tools in an anvil unsafe enchants works it will allow players to put efficiency x for example what i am also trying to do is allow players to add all the protection enchants in anvils to there gear with permissions so what i am asking is does this support that? because i was not able to make that happen and if it doesnt could you or would you be willing to add some support in the config to enable that

its the old enchant method from 1.16 i believe or 1.13

ShaneBeee commented 1 year ago

Either you are not telling me what you actually wanna do, or I am just not understanding what exactly you are looking for... but I have no clue what you are wanting to do.

Foxshot21 commented 1 year ago

?? with your plugin i can add enchants to tools in an anvil like eff 10 but what i also want to do is be able to add all the protection enchants to armour not just 1

Foxshot21 commented 1 year ago

as in prot 4 fire prot 4 projectile 4 all on 1 piece of armour is it possible for you to add support for this with a setting for it in the conf

ShaneBeee commented 1 year ago

you said its a vanilla thing, what do I need to add support for exactly?

Foxshot21 commented 1 year ago

ok as i said if you read the message it was in vanilla in 1.13 to about 1.16 and if you are not sure about enchants then it is ok i will move to another plugin as what i asked is rather clear and simple it (WAS) a vanilla enchanting method not anymore and if you cant add support for it then that is all good i will move to another plugin

ShaneBeee commented 1 year ago

if you cant add support for it

Add support for WHAT? I still have no clue what you are asking for. You want to add enchants with a level of 4, that's a vanilla thing... what do you need my plugin to do?

Foxshot21 commented 1 year ago

your plugin allows u to make a book with prot 4 fire prot 4 and projectile prot 4 but vanilla disabled this in 1.16 so you can make the book but you cant add it to armour making it useless tools however can be used to make a book with lvl 10 and added to tools in anvil no problem

the armour for lvl 4 prot of all 3 types cannot be added in vanilla but with your plugin i can make the book but still cannot add it to gear in the anvil

hopefully this is clear enough

ShaneBeee commented 1 year ago

ohhhhhhhhh you're talking about conflicts, I gotcha. (Sorry I don't actively play Minecraft, its been years since I have enchanted anything) Anyways there's a config option for that: https://github.com/ShaneBeee/EnchBook/blob/b7b577a09974bbd4ea3c5e26d637ec6b21ec0244/src/main/resources/config.yml#L13-L14

Foxshot21 commented 1 year ago

ok so this is what i was asking about but i have attempted to Ignore Conflicts: true and it will allow me to make the book but will not allow me to add it onto an item in an anvil this is my issue

ShaneBeee commented 1 year ago

you have to make sure safe enchants is false: https://github.com/ShaneBeee/EnchBook/blob/b7b577a09974bbd4ea3c5e26d637ec6b21ec0244/src/main/resources/config.yml#L7-L11

That together with ignore conflicts true, it works.

Foxshot21 commented 1 year ago

here is my conf

https://pastebin.com/7zBKd3Z4

everything works except adding the one book via an anvil which is the all 3 prot 4 book

ShaneBeee commented 1 year ago

Using your config, and making sure im not op'd:

Screenshot 2023-02-20 at 10 04 46 PM Screenshot 2023-02-20 at 10 04 48 PM

Needless to say it worked fine for me!

Foxshot21 commented 1 year ago

interesting ok i will run back through and see maybe it is something else that has stopped it then

sorry for the headache m8