ShaneBeee / EnchBook

GNU General Public License v3.0
3 stars 1 forks source link

Plugin allows combining items with books #7

Closed the1mason closed 2 years ago

the1mason commented 2 years ago

When safe books is true and safe enchants is false players can combine safe book with safe item. For example:
Player combines pickaxe-with-mending and mending without bypass permissions with safebooks set to true and safe enchants is `false.
Expected behavior:
Player gets Mending I
Actual behavior: Player gets Mending II

I think there could be another config parameter for unsafe items-books combining or it could use existing SafeBooks.

ShaneBeee commented 2 years ago

So... stupid me... I had this all setup before, but I forgot to add the actual config option to the config.

OOPS

The code was all written for it, I just never actually put it in config.yml, it will be in the next update, you shall see this in your config:

# Require permission when a player attempts to combine an item and book and the level goes higher than vanilla allows
# This can be bypassed with the permission 'enchbook.bypass.vanilla_max_level_item'
Above Vanilla Item Requires Permission: false
ShaneBeee commented 2 years ago

Fixed in https://github.com/ShaneBeee/EnchBook/releases/tag/1.4.3