ShaneBeee / SkBee

SkBee is a Skript addon that aims to add more useful elements to Skript.
GNU General Public License v3.0
7 stars 6 forks source link

SecClickEventCallback - Some minor cleanup changes #475

Closed Fusezion closed 1 year ago

Fusezion commented 1 year ago

Changes Made short and simple

Bit more detailed ones

The swap from EffectSection to Section was by tud pointing out on discord it didn't make much sense to use it if we can't allow one line usage anyways, the only reason I found why you'd do this is adding a custom error message, however I don't believe this a good practice to follow and believe it's best to stop before it's started.

Some cleanup to the class was made with the removal of nullable properties allowing a little bit easier readability. renamed the timeLimit field to lifeTime making it a bit more intuitive, and lastly made the event private as no where else will need this event.

lifetime was given the counterpart of duration which was accompanied by am optional [a] new format looks like [[and] with [a] (lifetime|duration) of %timespan%]

Additionally updated examples and added another one to make an example for all 3 usages of the section making it eaiser for people to understand