search

ShaneIsrael / fireshare

Self host your media and share with unique links
GNU General Public License v3.0
682 stars 41 forks source link

IPs recorded in sqlite file #120

Closed truthsword closed 2 years ago

truthsword commented 2 years ago

Why are IPs recorded in the sqlite file? What is the source (some I don't recognize). This seems unnecessary, and a security concern. For example:

INSERT INTO "video_view" VALUES (1,'e7xxxxxxxxxxxxxxxxxxa2ceff4306287','107.150.23.212');
INSERT INTO "video_view" VALUES (2,'f13xxxxxxxxxxxxxxxxxx5c061e43c9fdd','161.129.70.14');

Thank you!

ShaneIsrael commented 2 years ago

It's required to track video views and for your own knowledge. In the future I plan on having a display so that you can see how many hits/views your getting from a particular source. This is not a security risk, this is no different than your reverse proxy spitting out the ip addresses of anybody connecting to your proxy to the logs.