search

ShaneIsrael / fireshare

Self host your media and share with unique links
GNU General Public License v3.0
642 stars 39 forks source link

Fallback to v1.2.9. Added some handling to stand inplace of the manual file corruption check. #207

Closed J-Stuff closed 1 year ago

J-Stuff commented 1 year ago

After some more debugging, it looked best to fall back to v1.2.9 and add a try/except statement on the original line of code that was causing the errors in #191

The manual check with integv only caused issues in prod after the Dockerfile was built. So this should avoid it entirely. (Shane, I thank you immensely for putting up with this tom-fuckery of an idea)

J-Stuff commented 1 year ago

I found the issue in #191 was caused when recording using NVIDIA shadow play to the captures directory of Fireshare. Since the file was not fully "built" when fireshare attempted to scan the file.

ShaneIsrael commented 1 year ago

@J-Stuff No problem! Some improvements take a couple PR's to get right. I wish I had the time right now to help a bit more with it.

ShaneIsrael commented 1 year ago

I'll leave it in the develop build for now, let me know if you think its all good and I'll merge to main and do another release.

J-Stuff commented 1 year ago

Thanks. Would it be possible for a develop Docker Image to be built for testing. As I'm unable to build a working dockerfile for some reason.

ShaneIsrael commented 1 year ago

The develop branch has always had a docker image built when it is updated. its fireshare:develop, when you run it though the version will still reflect whatever the current main version is set to since I don't update develops version until I'm ready to make a new release.