search

ShaneIsrael / fireshare

Self host your media and share with unique links
GNU General Public License v3.0
681 stars 41 forks source link

[Suggestion]: Iframe Embed #221

Open simeonradivoev opened 11 months ago

simeonradivoev commented 11 months ago

Would love to see a way to embed a video using an Iframe, similar to youtube and other video websites. I think a fullscreen video with the thumbnail provided should be more than enough. Video player can specify a poster like this <video width="width" height="height" poster="placeholder.png" controls> Could be as simple as providing it an address like: https://website.example/#/e/<video-id>

ShaneIsrael commented 11 months ago

I could potentially add a ui element that copies an iframe code snippet with the fields set correctly. But until then, it should be pretty easy to do this yourself manually in the rare cases that its needed.

You just need to make sure your using the /w/ path to the video. i.e the path that you are given when you click on the "copy link" buttons. If you use the /#/w/ link it wont work as that is the link to the web ui's page for the video, not the video itself.

simeonradivoev commented 11 months ago

Well, there is an issue with that, it also includes other web elements, and it's not a fullscreen of the video. A new view with just the video in it is all that is needed I think even if there is no button to copy the link.

ShaneIsrael commented 11 months ago

Right click the video -> copy video link, you should get a link that looks like this which will work fine in an