ShaneMcC / docker-omsa

Dell OpenManage Server Administrator in Docker.
8 stars 2 forks source link

Newest version ? #4

Closed tigerblue77 closed 1 year ago

tigerblue77 commented 1 year ago

Hello, I tried your Docker image on my personal lab and it still works well ! Thanks for the job you've done here !

I was about to fork the project and try to upgrade it but I also found this similar GitHub project on which you participated and I would like to know which one is "the best" ? They are both old but this one (ShaneMcC/docker-omsa) seems a lot easier to understand.

Thanks in advance !

ShaneMcC commented 1 year ago

I don't recall participating in that other project.

I think they do very similar things though that one hasn't been updated for a while.

Looking at their Dockerfile they're trying to avoid running much of systemd and provide a handy shell script for running the image.

I just opted to run systemd in the container (generally ill-advised) and it seemed to work and so I left it at that.

tigerblue77 commented 1 year ago

My bad, I saw "Shane" in contributors but it's not you 😅

Maybe we could merge all projects in one clean and up-to-date project ? :) Maybe I can help.

I just opted to run systemd in the container (generally ill-advised) and it seemed to work and so I left it at that.

Yes, I have systemd errors in my docker logs + modprobe errors I fixed

ShaneMcC commented 1 year ago

Hmm, I'm not getting any (noteworthy) systemd or modprobe errors in my logs.

There is an error from enabling the rc.local.service about it which is https://bugzilla.redhat.com/show_bug.cgi?id=1516188

That bug suggests we don't even need that line and that systemd will "do the right thing" automatically with a generator, so I'll remove that now to reduce the noise. (Possibly a left over from an older version of the image)

ShaneMcC commented 1 year ago

I've done some minor tidying/updating of the Dockerfile etc in:

commit 9ed60b7f91df23e70358da299bcd9f8f4d1ddb2e commit 8c0e12d0bf01927df7447260d66b829de6e7e0c5 commit 4d9de662bdf05afd52e6085238061a1219a653c3

This also fixes an issue where instsvcdrv.service wasn't starting within the container.

This didn't seem to impact anything, but I'd prefer everything ran correctly.

ShaneMcC commented 1 year ago

I've also now upgraded to almalinux 9.1 in bfcab0daeed698f281ffa3133e953552d9359b04 and I believe this is now correctly installing the latest omsa version