search

ShaneSutro / Vestaboard

An API Wrapper for Vestaboards written in Python
MIT License
54 stars 10 forks source link

"pad = " format attribute error #25

Closed thilleary closed 2 years ago

thilleary commented 2 years ago

The following code has been reliably posting text strings or characters to our vestaboards:

########################### def postit(payload): vboard.post(payload) ###########################

process raw characters to Vestaboard

############################ def SendRaw(characters): vboard.raw(characters, pad='center')

Lately however, the following error is received:

error in SendRaw vboard.raw(characters, pad = 'center') TypeError: raw() got an unexpected keyword argument 'pad'

This seemed to occur just about the time Vestaboard launched its VB+ applications. Any related causes here?

ShaneSutro commented 2 years ago

I’ll take a look! To my knowledge, this is unrelated - that bug seems to be almost pointing to a previous build, but I’ll take a look. I know this was awhile ago, but could you add the version of the library you have installed and the Python version you’re using?

ShaneSutro commented 2 years ago

Looks like this was an edge case that happened when the character list was exactly 6 rows! It was fixed in PR #24 by @jsdiaz - moving the re-formatting after the list length validation corrected the issue and also prevented unnecessary checks when the list was exactly 6 rows. This will be fixed in release v1.1.0!

ShaneSutro commented 2 years ago

Fixed in v1.1.0 release!