search

ShanghaitechGeekPie / oj-backend

The Backend Part of PIEGON | GeekPie OJ Project
https://oj.geekpie.club/about
Apache License 2.0
5 stars 1 forks source link

Bug on creating course #19

Closed philipxyc closed 5 years ago

philipxyc commented 5 years ago

image

Not sure why, the response body: {"non_field_errors":["字段 code, year, semester 必须能构成唯一集合。"]}

EricDiao commented 5 years ago

Because you don't fill those fields correctly. As stated in the error message: non_field_errors.

philipxyc commented 5 years ago

The problem seem not that easy, I find I have created this course now, although there are an error occur. Probably could be frontend's problem.

BTW, the instructor field in creating course should be able to be non according to real situation

EricDiao commented 5 years ago

You mean instructor could be null? Then modify the database models to allow nullable attributes on instructor, DRF will follow the semantics provided by the models.

For fortend-related problem, shoot a issue to oj-frontend.

philipxyc commented 5 years ago

I think this is due to unspecified api definition. The api for creating course is resisted at /instructor/<str:uid>/course/, so the instructor that own this api address should eventually be the instr of this create course. BUT it seems that front end do it in the way that I mentioned above, and back end need the request itself contain the redundant message of this instructor. PLZ negotiate on this issue, I prefer the frontend's design. @EricDiao @Artanic30

philipxyc commented 5 years ago

Also PLZ be caution to every bug that occur when conducting integrity validation. The issue could be caused by bugs on backend, frontend or api design. You could only be sure of the problem is nothing to do with the backend if and only if you conduct the component validating and API validation with coverage of 100%

philipxyc commented 5 years ago

Another traceback:

MissingSchema at /api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/ Invalid URL '/user/xiayc%40shanghaitech.edu.cn': No schema supplied. Perhaps you meant http:///user/xiayc%40shanghaitech.edu.cn?

Request Method: POST Request URL: https://oj.geekpie.club/api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/ Django Version: 2.1.7 Python Executable: /usr/bin/python3 Python Version: 3.6.7 Python Path: ['/app', '/usr/local/bin', '/usr/lib/python36.zip', '/usr/lib/python3.6', '/usr/lib/python3.6/lib-dynload', '/usr/local/lib/python3.6/dist-packages', '/usr/lib/python3/dist-packages'] Server time: Sun, 30 Jun 2019 18:44:40 +0800 Installed Applications: ['django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.sessions', 'django.contrib.messages', 'django.contrib.staticfiles', 'oidc_rp', 'rest_framework', 'oj_database', 'oj_backend.backend'] Installed Middleware: ['django.middleware.security.SecurityMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware', 'django.middleware.clickjacking.XFrameOptionsMiddleware', 'oidc_rp.middleware.OIDCRefreshIDTokenMiddleware']

Traceback:

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/exception.py" in inner

  1. response = get_response(request)

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/base.py" in _get_response

  1. response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/base.py" in _get_response

  1. response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.6/dist-packages/django/views/decorators/csrf.py" in wrapped_view

  1. return view_func(*args, **kwargs)

File "/usr/local/lib/python3.6/dist-packages/django/views/generic/base.py" in view

  1. return self.dispatch(request, *args, **kwargs)

File "/usr/local/lib/python3.6/dist-packages/rest_framework/views.py" in dispatch

  1. response = self.handle_exception(exc)

File "/usr/local/lib/python3.6/dist-packages/rest_framework/views.py" in handle_exception

  1. self.raise_uncaught_exception(exc)

File "/usr/local/lib/python3.6/dist-packages/rest_framework/views.py" in dispatch

  1. response = handler(request, *args, **kwargs)

File "/app/oj_backend/backend/views.py" in post

  1. if not MW_if_user_exists(instr.enroll_email):

File "/app/oj_backend/backend/middleware_connector.py" in MW_if_user_exists

  1. r = requests.get('/user/{}'.format(quote(email)))

File "/usr/local/lib/python3.6/dist-packages/requests/api.py" in get

  1. return request('get', url, params=params, **kwargs)

File "/usr/local/lib/python3.6/dist-packages/requests/api.py" in request

  1. return session.request(method=method, url=url, **kwargs)

File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py" in request

  1. prep = self.prepare_request(req)

File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py" in prepare_request

  1. hooks=merge_hooks(request.hooks, self.hooks),

File "/usr/local/lib/python3.6/dist-packages/requests/models.py" in prepare

  1. self.prepare_url(url, params)

File "/usr/local/lib/python3.6/dist-packages/requests/models.py" in prepare_url

  1. raise MissingSchema(error)

Exception Type: MissingSchema at /api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/ Exception Value: Invalid URL '/user/xiayc%40shanghaitech.edu.cn': No schema supplied. Perhaps you meant http:///user/xiayc%40shanghaitech.edu.cn? Request information: USER: rDR41po8gfpi5g9cNpYWWk5easQ

GET: No GET data

POST: No POST data

FILES: No FILES data

COOKIES: csrftoken = 'RvJEpDS9dFR5NnLoRFbqNMLXANHWBE5JBgC91yjMAAnTu62i727wuFXUzuKtFR3e' sessionid = '8vno7db08cupilnn1g3mgqpsvqlt27d5'

META: CONTENT_LENGTH = '118' CONTENT_TYPE = 'application/json;charset=UTF-8' CSRF_COOKIE = 'RvJEpDS9dFR5NnLoRFbqNMLXANHWBE5JBgC91yjMAAnTu62i727wuFXUzuKtFR3e' HTTP_ACCEPT = 'application/json, text/plain, /' HTTP_ACCEPT_ENCODING = 'gzip, deflate, br' HTTP_ACCEPT_LANGUAGE = 'en-US,en;q=0.9' HTTP_CONNECTION = 'close' HTTP_COOKIE = 'csrftoken=RvJEpDS9dFR5NnLoRFbqNMLXANHWBE5JBgC91yjMAAnTu62i727wuFXUzuKtFR3e; sessionid=8vno7db08cupilnn1g3mgqpsvqlt27d5' HTTP_HOST = 'oj.geekpie.club' HTTP_ORIGIN = 'https://oj.geekpie.club' HTTP_REFERER = 'https://oj.geekpie.club/instr/course' HTTP_USER_AGENT = 'Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Mobile Safari/537.36' HTTP_X_CSRFTOKEN = 'RvJEpDS9dFR5NnLoRFbqNMLXANHWBE5JBgC91yjMAAnTu62i727wuFXUzuKtFR3e' HTTP_X_FORWARDED_FOR = '59.78.171.202,10.42.59.187' HTTP_X_FORWARDED_PORT = '443' HTTP_X_FORWARDED_PROTO = 'https' HTTP_X_REQUESTED_WITH = 'XMLHttpRequest' PATH_INFO = '/api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/' QUERY_STRING = '' RAW_URI = '/api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/' REMOTE_ADDR = '10.42.170.194' REMOTE_PORT = '55680' REQUEST_METHOD = 'POST' SCRIPT_NAME = '' SERVER_NAME = '0.0.0.0' SERVER_PORT = '8080' SERVER_PROTOCOL = 'HTTP/1.1' SERVER_SOFTWARE = 'gunicorn/19.9.0' gunicorn.socket = <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('10.42.36.77', 8080), raddr=('10.42.170.194', 55680)> wsgi.errors = <gunicorn.http.wsgi.WSGIErrorsWrapper object at 0x7fd3e7849e80> wsgi.file_wrapper = '' wsgi.input = <gunicorn.http.body.Body object at 0x7fd3e78496a0> wsgi.multiprocess = True wsgi.multithread = False wsgi.run_once = False wsgi.url_scheme = 'http' wsgi.version = '(1, 0)'

Settings: Using settings module oj_backend.settings ABSOLUTE_URL_OVERRIDES = {} ADMINS = [] ALLOWED_HOSTS = ['oj.geekpie.club', 'backend'] APPEND_SLASH = True AUTHENTICATION_BACKENDS = "('oidc_rp.backends.OIDCAuthBackend',)" AUTH_PASSWORD_VALIDATORS = '****' AUTH_USER_MODEL = 'oj_database.User' BASE_DIR = '/app' CACHES = {'default': {'BACKEND': 'django_redis.cache.RedisCache', 'LOCATION': 'redis://redis:6379/0', 'OPTIONS': {'CLIENT_CLASS': 'django_redis.client.DefaultClient'}}} CACHE_MIDDLEWARE_ALIAS = 'default' CACHE_MIDDLEWARE_KEY_PREFIX = '****' CACHE_MIDDLEWARE_SECONDS = 600 CSRF_COOKIE_AGE = 31449600 CSRF_COOKIE_DOMAIN = None CSRF_COOKIE_HTTPONLY = False CSRF_COOKIE_NAME = 'csrftoken' CSRF_COOKIE_PATH = '/' CSRF_COOKIE_SAMESITE = 'Lax' CSRF_COOKIE_SECURE = False CSRF_FAILURE_VIEW = 'django.views.csrf.csrf_failure' CSRF_HEADER_NAME = 'HTTP_X_CSRFTOKEN' CSRF_TRUSTED_ORIGINS = [] CSRF_USE_SESSIONS = False DATABASES = {'default': {'ENGINE': 'django.db.backends.mysql', 'NAME': 'ojtest', 'USER': 'ojtest', 'PASSWORD': '****', 'HOST': 'mysql', 'PORT': '3306', 'ATOMIC_REQUESTS': False, 'AUTOCOMMIT': True, 'CONN_MAX_AGE': 0, 'OPTIONS': {}, 'TIME_ZONE': None, 'TEST': {'CHARSET': None, 'COLLATION': None, 'NAME': None, 'MIRROR': None}}} DATABASE_ROUTERS = [] DATA_UPLOAD_MAX_MEMORY_SIZE = 2621440 DATA_UPLOAD_MAX_NUMBER_FIELDS = 1000 DATETIME_FORMAT = 'N j, Y, P' DATETIME_INPUT_FORMATS = ['%Y-%m-%d %H:%M:%S', '%Y-%m-%d %H:%M:%S.%f', '%Y-%m-%d %H:%M', '%Y-%m-%d', '%m/%d/%Y %H:%M:%S', '%m/%d/%Y %H:%M:%S.%f', '%m/%d/%Y %H:%M', '%m/%d/%Y', '%m/%d/%y %H:%M:%S', '%m/%d/%y %H:%M:%S.%f', '%m/%d/%y %H:%M', '%m/%d/%y'] DATE_FORMAT = 'N j, Y' DATE_INPUT_FORMATS = ['%Y-%m-%d', '%m/%d/%Y', '%m/%d/%y', '%b %d %Y', '%b %d, %Y', '%d %b %Y', '%d %b, %Y', '%B %d %Y', '%B %d, %Y', '%d %B %Y', '%d %B, %Y'] DEBUG = True DEBUG_PROPAGATE_EXCEPTIONS = False DECIMAL_SEPARATOR = '.' DEFAULT_CHARSET = 'utf-8' DEFAULT_CONTENT_TYPE = 'text/html' DEFAULT_EXCEPTION_REPORTER_FILTER = 'django.views.debug.SafeExceptionReporterFilter' DEFAULT_FILE_STORAGE = 'django.core.files.storage.FileSystemStorage' DEFAULT_FROM_EMAIL = 'webmaster@localhost' DEFAULT_INDEX_TABLESPACE = '' DEFAULT_TABLESPACE = '' DISALLOWED_USER_AGENTS = [] EMAIL_BACKEND = 'django.core.mail.backends.smtp.EmailBackend' EMAIL_HOST = 'localhost' EMAIL_HOST_PASSWORD = '****' EMAIL_HOST_USER = '' EMAIL_PORT = 25 EMAIL_SSL_CERTFILE = None EMAIL_SSL_KEYFILE = '****' EMAIL_SUBJECT_PREFIX = '[Django] ' EMAIL_TIMEOUT = None EMAIL_USE_LOCALTIME = False EMAIL_USE_SSL = False EMAIL_USE_TLS = False FILE_CHARSET = 'utf-8' FILE_UPLOAD_DIRECTORY_PERMISSIONS = None FILE_UPLOAD_HANDLERS = ['django.core.files.uploadhandler.MemoryFileUploadHandler', 'django.core.files.uploadhandler.TemporaryFileUploadHandler'] FILE_UPLOAD_MAX_MEMORY_SIZE = 2621440 FILE_UPLOAD_PERMISSIONS = None FILE_UPLOAD_TEMP_DIR = None FIRST_DAY_OF_WEEK = 0 FIXTURE_DIRS = [] FORCE_SCRIPT_NAME = None FORMAT_MODULE_PATH = None FORM_RENDERER = 'django.forms.renderers.DjangoTemplates' IGNORABLE_404_URLS = [] INSTALLED_APPS = ['django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.sessions', 'django.contrib.messages', 'django.contrib.staticfiles', 'oidc_rp', 'rest_framework', 'oj_database', 'oj_backend.backend'] INTERNAL_IPS = [] LANGUAGES = [('af', 'Afrikaans'), ('ar', 'Arabic'), ('ast', 'Asturian'), ('az', 'Azerbaijani'), ('bg', 'Bulgarian'), ('be', 'Belarusian'), ('bn', 'Bengali'), ('br', 'Breton'), ('bs', 'Bosnian'), ('ca', 'Catalan'), ('cs', 'Czech'), ('cy', 'Welsh'), ('da', 'Danish'), ('de', 'German'), ('dsb', 'Lower Sorbian'), ('el', 'Greek'), ('en', 'English'), ('en-au', 'Australian English'), ('en-gb', 'British English'), ('eo', 'Esperanto'), ('es', 'Spanish'), ('es-ar', 'Argentinian Spanish'), ('es-co', 'Colombian Spanish'), ('es-mx', 'Mexican Spanish'), ('es-ni', 'Nicaraguan Spanish'), ('es-ve', 'Venezuelan Spanish'), ('et', 'Estonian'), ('eu', 'Basque'), ('fa', 'Persian'), ('fi', 'Finnish'), ('fr', 'French'), ('fy', 'Frisian'), ('ga', 'Irish'), ('gd', 'Scottish Gaelic'), ('gl', 'Galician'), ('he', 'Hebrew'), ('hi', 'Hindi'), ('hr', 'Croatian'), ('hsb', 'Upper Sorbian'), ('hu', 'Hungarian'), ('ia', 'Interlingua'), ('id', 'Indonesian'), ('io', 'Ido'), ('is', 'Icelandic'), ('it', 'Italian'), ('ja', 'Japanese'), ('ka', 'Georgian'), ('kab', 'Kabyle'), ('kk', 'Kazakh'), ('km', 'Khmer'), ('kn', 'Kannada'), ('ko', 'Korean'), ('lb', 'Luxembourgish'), ('lt', 'Lithuanian'), ('lv', 'Latvian'), ('mk', 'Macedonian'), ('ml', 'Malayalam'), ('mn', 'Mongolian'), ('mr', 'Marathi'), ('my', 'Burmese'), ('nb', 'Norwegian Bokmål'), ('ne', 'Nepali'), ('nl', 'Dutch'), ('nn', 'Norwegian Nynorsk'), ('os', 'Ossetic'), ('pa', 'Punjabi'), ('pl', 'Polish'), ('pt', 'Portuguese'), ('pt-br', 'Brazilian Portuguese'), ('ro', 'Romanian'), ('ru', 'Russian'), ('sk', 'Slovak'), ('sl', 'Slovenian'), ('sq', 'Albanian'), ('sr', 'Serbian'), ('sr-latn', 'Serbian Latin'), ('sv', 'Swedish'), ('sw', 'Swahili'), ('ta', 'Tamil'), ('te', 'Telugu'), ('th', 'Thai'), ('tr', 'Turkish'), ('tt', 'Tatar'), ('udm', 'Udmurt'), ('uk', 'Ukrainian'), ('ur', 'Urdu'), ('vi', 'Vietnamese'), ('zh-hans', 'Simplified Chinese'), ('zh-hant', 'Traditional Chinese')] LANGUAGES_BIDI = ['he', 'ar', 'fa', 'ur'] LANGUAGE_CODE = 'zh-cn' LANGUAGE_COOKIE_AGE = None LANGUAGE_COOKIE_DOMAIN = None LANGUAGE_COOKIE_NAME = 'django_language' LANGUAGE_COOKIE_PATH = '/' LOCALE_PATHS = [] LOGGING = {'version': 1, 'disable_existing_loggers': False, 'handlers': {'console': {'class': 'logging.StreamHandler'}}, 'loggers': {'django': {'handlers': ['console'], 'level': 'DEBUG'}, 'djangodjango.request': {'handlers': ['console'], 'level': 'DEBUG'}, 'djangodjango.server': {'handlers': ['console'], 'level': 'DEBUG'}, 'backend.main': {'handlers': ['console'], 'level': 'DEBUG'}}} LOGGING_CONFIG = 'logging.config.dictConfig' LOGIN_REDIRECT_URL = 'https://oj.geekpie.club/' LOGIN_URL = '/accounts/login/' LOGOUT_REDIRECT_URL = 'https://oj.geekpie.club/' MANAGERS = [] MEDIA_ROOT = '' MEDIA_URL = '' MESSAGE_STORAGE = 'django.contrib.messages.storage.fallback.FallbackStorage' MIDDLEWARE = ['django.middleware.security.SecurityMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware', 'django.middleware.clickjacking.XFrameOptionsMiddleware', 'oidc_rp.middleware.OIDCRefreshIDTokenMiddleware'] MIGRATION_MODULES = {} MONTH_DAY_FORMAT = 'F j' NUMBER_GROUPING = 0 OIDC_EXEMPT_URLS = ['/api/user/login/oauth/param', '/api/user/auth/oidc/param'] OIDC_RP_CLIENT_ID = '416378' OIDC_RP_CLIENT_SECRET = '****' OIDC_RP_PROVIDER_ENDPOINT = 'https://gauth.geekpie.club/openid/' OIDC_RP_SCOPES = 'openid profile email identification identification_shanghaitech_realname identification_shanghaitech_id identification_shanghaitech_role' OIDC_RP_SIGN_ALGO = 'HS256' OIDC_RP_USER_DETAILS_HANDLER = 'oj_backend.backend.users.oidc_user_update_handler' OJBN_INTERNAL_HOSTNAME = 'backend' OJ_ENFORCE_HTTPS = True OJ_SUBMISSION_TOKEN = '****' PASSWORD_HASHERS = '****' PASSWORD_RESET_TIMEOUT_DAYS = '****' PREPEND_WWW = False ROOT_URLCONF = 'oj_backend.urls' SECRET_KEY = '****' SECURE_BROWSER_XSS_FILTER = False SECURE_CONTENT_TYPE_NOSNIFF = False SECURE_HSTS_INCLUDE_SUBDOMAINS = False SECURE_HSTS_PRELOAD = False SECURE_HSTS_SECONDS = 0 SECURE_PROXY_SSL_HEADER = "('HTTP_X_FORWARDED_PROTO', 'https')" SECURE_REDIRECT_EXEMPT = [] SECURE_SSL_HOST = None SECURE_SSL_REDIRECT = False SERVER_EMAIL = 'root@localhost' SESSION_CACHE_ALIAS = 'default' SESSION_COOKIE_AGE = 1209600 SESSION_COOKIE_DOMAIN = None SESSION_COOKIE_HTTPONLY = True SESSION_COOKIE_NAME = 'sessionid' SESSION_COOKIE_PATH = '/' SESSION_COOKIE_SAMESITE = 'Lax' SESSION_COOKIE_SECURE = False SESSION_ENGINE = 'django.contrib.sessions.backends.db' SESSION_EXPIRE_AT_BROWSER_CLOSE = False SESSION_FILE_PATH = None SESSION_SAVE_EVERY_REQUEST = False SESSION_SERIALIZER = 'django.contrib.sessions.serializers.JSONSerializer' SETTINGS_MODULE = 'oj_backend.settings' SHORT_DATETIME_FORMAT = 'm/d/Y P' SHORT_DATE_FORMAT = 'm/d/Y' SIGNING_BACKEND = 'django.core.signing.TimestampSigner' SILENCED_SYSTEM_CHECKS = [] STATICFILES_DIRS = [] STATICFILES_FINDERS = ['django.contrib.staticfiles.finders.FileSystemFinder', 'django.contrib.staticfiles.finders.AppDirectoriesFinder'] STATICFILES_STORAGE = 'django.contrib.staticfiles.storage.StaticFilesStorage' STATIC_ROOT = None STATIC_URL = '/static/' TEMPLATES = [{'BACKEND': 'django.template.backends.django.DjangoTemplates', 'DIRS': [], 'APP_DIRS': True, 'OPTIONS': {'context_processors': ['django.template.context_processors.debug', 'django.template.context_processors.request', 'django.contrib.auth.context_processors.auth', 'django.contrib.messages.context_processors.messages', 'oidc_rp.context_processors.oidc']}}] TEST_NON_SERIALIZED_APPS = [] TEST_RUNNER = 'django.test.runner.DiscoverRunner' THOUSAND_SEPARATOR = ',' TIME_FORMAT = 'P' TIME_INPUT_FORMATS = ['%H:%M:%S', '%H:%M:%S.%f', '%H:%M'] TIME_ZONE = 'Asia/Shanghai' USE_I18N = True USE_L10N = True USE_THOUSAND_SEPARATOR = False USE_TZ = True USE_X_FORWARDED_HOST = False USE_X_FORWARDED_PORT = False WSGI_APPLICATION = 'oj_backend.wsgi.application' X_FRAME_OPTIONS = 'SAMEORIGIN' YEAR_MONTH_FORMAT = 'F Y'

You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard page generated by the handler for this status code.

philipxyc commented 5 years ago

This API problem is solved, the definition of api remains the same. However, new problem occurred: when POST correct request to create course, 500 was returned. Response detail:

Request URL: https://oj.geekpie.club/api/instructor/da196608-98b0-11e9-a648-029eb8f8b328/course/ Request Method: POST Status Code: 500 Internal Server Error Response: {"cuase": "Git server error."}