search

ShangtongZhang / DeepRL

Modularized Implementation of Deep RL Algorithms in PyTorch
MIT License
3.21k stars 684 forks source link

fix a minor issue replay.py #103

Open ainilaha opened 4 years ago

ainilaha commented 4 years ago

  1. A keyword async used as a parameter in the __init__(self, replay_cls, replay_kwargs, async=True): function of ReplayWrapper, and it raises a syntax error when I run the code on a local machine with python 3.5 and 3.8 (I have not tried with docker). 

    >>> import keyword
>>> keyword.kwlist
['False', 'None', 'True', 'and', 'as', 'assert', 'async',...

    Therefore, async has been replaced with async_flag.

  2. It seems unnecessary to pass the async=True in the examples.py because the default value is True.