ShangtongZhang / reinforcement-learning-an-introduction

Python Implementation of Reinforcement Learning: An Introduction
MIT License
13.45k stars 4.81k forks source link

A simpler draw function #135

Open rohitdavas opened 3 years ago

rohitdavas commented 3 years ago

In chapter03 draw_image function, I think the function can be better wrote as :

![example](https://user-images.githubusercontent.com/52150408/96678148-b6e9ee00-138e-11eb-8fe7-419d1245fbe7.png)
def drawTable(matrix):
    data = np.asarray(matrix, str) 
    _, axes = plt.subplots()
    axes.set_axis_off()

    table(ax = axes,
          cellText=data, 
          cellLoc='center',
          bbox=[0,0,1,1], 
          edges='closed',
          )

    plt.savefig ("./example.png")
    plt.close() 

example

Michael1015198808 commented 3 years ago

But this method seems to ignore the markers A, B? Maybe we can add another function parse_matrix and then write the code like

def drawTable(matrix):
    data = parse_matrix(matrix)

And move the logic of adding markers A into the function parse_matrix

rohitdavas commented 3 years ago

Yes. The purpose of this is to draw any matrix. I didn’t pass A,B annotated matrix to draw, otherwise it would have plotted so.