improve: revert C++ override keyword back to final - Githubissues

Shannon-Data / ShannonBase

A MySQL HTAP Database, Open Source version of MySQL Heatwave, Powered by AI.

https://www.shannonbase.org

Other

16 stars 6 forks source link

improve: revert C++ override keyword back to final #181

Open db-lover opened 5 months ago

db-lover commented 5 months ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Version

There has been in each release.

What's Wrong?

In Field_longlong type define:

class Field_longlong : public Field_num {
...
  double val_real() const override;
...
}

funciton val_real() marked as override, it is not inherited by Field_sys_trx_id. In native MySQL 8.0, this function is marked as final

How to Reproduce?

No response

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!