search

Shaosil / LethalCompanyMods-GeneralImprovements

A general improvements mod for Lethal Company
https://thunderstore.io/c/lethal-company/p/ShaosilGaming/GeneralImprovements/changelog/
8 stars 7 forks source link

Quota rollover does not let you advance to next quota #111

Closed ShadowzOfTheDark closed 6 months ago

ShadowzOfTheDark commented 9 months ago

Made a fresh r2modman profile with only general improvements and enabling quota rollover.

To reproduce just play the game until you can go to the company building and sell to make quota. Once you sell the items and launch the ship the quota rollover functionality will not work correctly. Instead the day will not advance and you will be effectively softlocked at 0 days until profit quota.

Did not check if you can go to other moons and still play in this state but I still feel like this is probably not intended.

Shaosil commented 9 months ago

Hmm, I haven't seen this reported (or experienced it myself) yet - could you give me your profile code so I can test it for myself?

Typically if the day won't advance, that means there was an error somewhere that prevented certain code from executing. I'm curious what might be happening.

Just to confirm: 1) Play game, accumulate loot 2) On day 0, go to company 3) Sell past quota 4) Take off

And it gets stuck there?

ZachHaber commented 9 months ago

I had this issue yesterday, luckily, I've been backing up our save files a lot.

In this save file (I've tried it twice now to double-check that its reproducible), you travel to the company building, then take off (or sell a bunch and then take off, that part doesn't matter). The new quota is never displayed and it remains at day 0. I've included both the save file, and the entire mod profile to make it able to be played. Especially since I have no idea where to start on reproducing it from scratch...

We managed to get out of it in the original playthrough by navigating to a moon and then landing there and playing "day 0 part 2" at a moon. When I tried just now, it wasn't letting me land on any moons without going to the company building first (even after taking off from there).

Bugged Save.zip

ShadowzOfTheDark commented 9 months ago

I have a save and profile that can successfully reproduce this issue. I also was able to reproduce the issue using ZackHaber's save and profile but I think it's a less accurate example of the issue as it has a handful of other mods.

As stated before. This is a completely vanilla lethal company profile except for GeneralImprovements, BepInExPack and the quota rollover config being set to true.

To create this save I created a brand new save and just played the game up until the last day until quota deadline.

This save is right before you sell all the scrap. If you sell all the scrap you will wind up in the scenario I described earlier where the day never advances and you get stuck at 0 days until deadline.

I also looked at the logs and there is no errors or warnings printed. Searching through "GeneralImprovements" also just yields only debug info. Perhaps I need to turn some kind of verbose mode on?

Either way this zip file has the save file, profile file, profile code and my log output of the game.

QuotaRolloverBugReplication.zip

ShadowzOfTheDark commented 9 months ago

Here is a video displaying the issue.

https://youtu.be/DcyB_OJIqWc?t=85

stdcall0 commented 8 months ago

Same here, I had this issue with my friends, I think it might possibly be a mod conflict with Advanced Company's Extend Deadline feature.

After turning that off in AdvCom profile page, we haven't encountered the issue so far.

It is also worth mentioning, when the issue happens you can pilot the ship to any moon and after landing off the deadline will be refreshed.

Shaosil commented 8 months ago

After turning that off in AdvCom profile page, we haven't encountered the issue so far.

@ShadowzOfTheDark and @ZachHaber does stdcall0's solution also work for you guys? I haven't had a chance to look into this yet, but "mod conflict" does seem the most likely culprit.

ZachHaber commented 8 months ago

The same workaround works for me, though with ShadowzOfTheDark mentioned they only have this mod on the save file, so it might not be just mod conflicts. I don't remember this issue happening with the QuotaRollover mod when I played with it, though admittedly, that wasn't for as long as I've played with this one - https://thunderstore.io/c/lethal-company/p/boxofbiscuits97/QuotaRollover

ShadowzOfTheDark commented 8 months ago

@Shaosil I don't have any other mods in my mod list other than general improvements so it cannot be a mod conflict issue.

Shaosil commented 6 months ago

I finally fixed this! v1.2.4 is going live shortly and should have the fix in.

In some cases (like on your particular save), it may still play the "zero days left" audio after selling your items, but everything else should be working.