Shaosil / LethalCompanyMods-GeneralImprovements

A general improvements mod for Lethal Company
https://thunderstore.io/c/lethal-company/p/ShaosilGaming/GeneralImprovements/changelog/
8 stars 6 forks source link

[Question/Request] GI cam fps limiter #221

Open ajsglist opened 1 week ago

ajsglist commented 1 week ago

Hey there,

So OBC recently got an update to fix frame limiting for the custom bodycam. GI has had a frame limiter for the longest time for the vanilla interior/exterior cams. I think I may have been confusing the two, because for whatever reason I assumed GI limiting the FPS of these cams had a performance cost instead of potential gains.

Do you know offhand if limiting the cam fps through GI boosts performance based on the chosen FPS cap? And does the uncapped option "0" represent these cams rendering every frame? And if that's the case, would it be possible to increase the GI limit from 30 fps to 60 fps, which should still increase performance while allowing smoother internal/external cams?

Thanks

Shaosil commented 1 week ago

Whoops, I saw your question and forgot to reply in the closed issue :)

OBC having the update to fix frame limiting was part of our findings for the last big performance update actually. But it completely relies on us setting a property on our cameras (along with some other things) to take advantage of the internal rendering optimizations.

As it stands, the ship cams are still using vanilla cameras and setting them to 0 (unrestricted) currently results in the best performance in most cases, so increasing the allowed limits from 30 to 60 would do more bad than good, I believe.

That being said, I wonder if I can just apply the same optimization to the vanilla cameras if a FPS limit is applied. I'll leave this open for now to remind me to look into that sometime.