Some of the code may be wrong.

Sharath-girish / efficientgaussian

Official implementation of "EAGLES: Efficient Accelerated 3D Gaussians with Lightweight EncodingS"

https://efficientgaussian.github.io/

Other

131 stars 6 forks source link

Some of the code may be wrong. #6

Closed Mike001-wq closed 2 months ago

Mike001-wq commented 3 months ago

Should lines 234 and 235 in utils/general_utils.py be swapped? First record the val with the lowest probability, then replace it with the value with the highest probability. `

        weight[weight == val] = unique_vals[counts.argmax()]

        self.tail_locs[val.item()] = torch.where(weight == val)[0].detach().cpu()`

Sharath-girish commented 2 months ago

Thanks for highlighting this bug. It is now fixed in a recent commit (1cfc84d). Feel free to reopen if there are any issues.