SharePoint / PnP-JS-Core

Code moved to https://github.com/pnp/pnpjs. This repository is archived.
Other
379 stars 231 forks source link

Added missing options to RenderListDataParameters #742

Closed phawrylak closed 6 years ago

phawrylak commented 6 years ago
Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]

What's in this Pull Request?

Added missing options to RenderListDataParameters and RenderListDataOptions used in RenderListDataAsStream method.

masterl1983 commented 6 years ago

Nice one. I think this RenderListDataAsStream method will become my favorit method zo use when building custom grids.

patrick-rodgers commented 6 years ago

Thanks! Will get this merged in time for the next release.

masterl1983 commented 6 years ago

Do you know what RenderOptions: 5639 is? This values is used when by Sharepoint when you switch the view of a sharepoint list.

phawrylak commented 6 years ago

@masterl1983, yes, that's just: RenderOptions: RenderListDataOptions.ContextInfo | RenderListDataOptions.ListData | RenderListDataOptions.ListSchema | RenderListDataOptions.Visualization | RenderListDataOptions.ViewMetadata | RenderListDataOptions.EnableMediaTAUrls

I have used that to get OneDrive thumbnails URLs used in modern tile view for my custom search display templates and web parts. I can share some example if you want (I will probably do it anyway as some PR to SPFx Search Web Part with Refiners sample).

masterl1983 commented 6 years ago

Examples are always welcome :-)

phawrylak commented 6 years ago

Gist: Example of getting OneDrive thumbnail URL for SharePoint List Item using method from modern list tile view

patrick-rodgers commented 6 years ago

Thanks!