search

SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.25k stars 1.01k forks source link

SPFx solutions not loaded from Office 365 CDN with SPFx documentation configuration #4695

Closed jhholm closed 5 years ago

jhholm commented 5 years ago

Category

Expected or Desired Behavior

SPFx Clientside solutions would be loaded from Office 365 Public CDN

Observed Behavior

SPFx Clientside solutions are not loaded from Office 365 Public CDN

Steps to Reproduce

  1. Create an app catalog on your tenant if you do not already have one
  2. Configure Office 365 Public CDN with default origins as documented in https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/get-started/hosting-webpart-from-office-365-cdn
  3. Wait until the CDN origins are provisioned
  4. Upload your solution to the appcatalog
  5. Add the app to a new team site
  6. Wait for 15 minutes to an hour, just to be sure that the app is provisioned to CDN
  7. See from Chrome development tools Sources tab that App is still loaded from your tenant instead of CDN.
  8. Get the JavaScript URL for your app from Chrome developer tools, and test with e.g. postman that you can manually fetch the JavaScript from public CDN by adding https://publiccdn.sharepointonline.com/ to the beginning of the url

I've tested this with a few tenants now: An older tenant and a fresh development tenant. SPFx JS files are still loaded after a 3 day waiting period from SharePoint instead of Office 365 CDN. The files are located in the CDN, but any URL rewrite is not happening.

Bug or outdated documentation?

msft-github-bot commented 5 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

andrewconnell commented 5 years ago

Did you bundle & package your projects with the --ship or -p flag?

One difference between a debug & production build is that the debug build doesn't rewrite the URL, it assumes the files are coming from your local webserver.

jhholm commented 5 years ago

I'm pretty sure I did and I retested just in case, no change. I'm also using https://github.com/SharePoint/sp-dev-solutions/releases - PnP Modern Search latest release package. I reckon it should be configured properly by looking at the config files. Both my own and that modern search webparts are loading from SharePoint. Using SPFx 1.8.2.

andrewconnell commented 5 years ago

@jhholm said:

are loading from SharePoint

What are you referring to when you say this? You haven't provided the exact URL that you are seeing and what you expect it to be which makes it hard to fully understand your solution.

jhholm commented 5 years ago

Just to be sure. I created a new SPFx 1.9.1 webpart and bundled and packaged it with --ship flags. Added that webpart to the landing page on a fresh team site.

The JS-file is loaded by the browser from the following URL: https://MYTENANTHERE.sharepoint.com/sites/apps/ClientSideAssets/7e1276e5-190e-43f3-8e92-4c4a1912964c/hello-world-web-part_c3cd8ef80cc9e8c67961745458adf848.js

Checking via postman, and using the correct Referer header, I can get the JS-file loaded via the following URL: https://publiccdn.sharepointonline.com/MYTENANTHERE.sharepoint.com/sites/apps/ClientSideAssets/7e1276e5-190e-43f3-8e92-4c4a1912964c/hello-world-web-part_c3cd8ef80cc9e8c67961745458adf848.js

jhholm commented 5 years ago

So what is happening is that the webpart is not loaded from CDN right now, even though it actually can be loaded from there manually.

andrewconnell commented 5 years ago

NOW I understand... thanks.

This sounds more like a system issue or a config issue with your tenant. You say you've enabled the CDN, it says the CDN is enabled on the origins, but the URL rewriting isn't happening. Can you share the results of the allowed origins for the site collection listed above when you request it using the POSH / Office 365 CLI commands?

If the configuration is correct, that's not something we're going to be able to investigate/address here in this list (which is for dev issues). My recommendation is to open a ticket via your SharePoint admin center to report the issue.

jhholm commented 5 years ago

Using the default configuration in my development tenant /MASTERPAGE /STYLE LIBRARY */CLIENTSIDEASSETS

I've tested this with a few different tenants / customers right now in North Europe. Successfully used CDN for a longer time on classic sites and I remember this working at some point. I was hoping that, as this seems to look like a system issue, it would be possible to find a target for a fix here easier than from regular admin center tickets.

I'll continue via admin center then.

andrewconnell commented 5 years ago

This issue list is for development issues. Unfortunately, there's zero that we can do here to fix the CDN if it's not working :-/

msft-github-bot commented 4 years ago

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues