SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.23k stars 992 forks source link

ACE QuickView Action Buttons with Deep Links not working on Mobile Teams Dashboard #7537

Closed Ismael-Cruz closed 1 year ago

Ismael-Cruz commented 2 years ago

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

Windows

What browser(s) / client(s) have you tested

Additional environment details

Describe the bug / error

If you add Buttons in the QuickView adaptive card with Deep Links, it opens the URL in the browser, it goes back to Teams app but stays in the QuickView where you clicked, it never navigates to that URL.

Steps to reproduce

  1. Add an Action.OpenURL in the QuickView adaptive card with a Teams Deep Link (i.e.: https://teams.microsoft.com/l/entity/APP_ID/ENTITY_ID).
  2. When clicking on it, it will do the redirect cycle through the browser, but when going back to teams it will stay in the QuickView.

Expected behavior

Best expected behavior:

Expected behavior for this issue:

ghost commented 2 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

patmill commented 2 years ago

Thanks @Ismael-Cruz - looking into this. This is a totally valid scenario. Following up with the mobile app folks. In the meantime, can you confirm that the target is an app that is installed on the users device, and that it is allowed on mobile. Also - can you try and add the same app as a Teams Card and see if that executes a deep link correctly?

Ismael-Cruz commented 2 years ago

Thanks @Ismael-Cruz - looking into this. This is a totally valid scenario. Following up with the mobile app folks. In the meantime, can you confirm that the target is an app that is installed on the users device, and that it is allowed on mobile. Also - can you try and add the same app as a Teams Card and see if that executes a deep link correctly?

I confirm that the app is installed on the users device. In fact, if I add the link while clicking on the CardView of the ACE (where you can specify the property "isTeamsDeepLink" to true, using the method "onCardSelection") it works fine, redirecting to the specific Tab in the selected App, and without redirecting through the browser.

I tested with a Teams Card and it executes the deep link properly. The problem seems to be exclusive to the QuickView in the Adaptive Card Extension (Maybe because it is in a popup view?).

As added information: I tried both with the ActionSet (both by Action.Submit and Action.OpenURL) and a hyperlink in the text.

Ismael-Cruz commented 2 years ago

UPDATE: After several more tests we found that the issue happens only in the Teams App for iOS, on Android it seems to work fine. Tested in:

patmill commented 2 years ago

Thanks for the additional info - that helps us.

dennisjsyi commented 1 year ago

Sorry for the late reply. We have identified the issue and will be creating a fix for it.

harshdamaniahd commented 1 year ago

Also, if we have an external link on the quickview (not a team deep link url) , it doesn't open inside the inbuilt browser. instead it opens outside teams, in browser @dennisjsyi

dennisjsyi commented 1 year ago

Hi @harshdamaniahd it is expected external links open outside of teams. Here is the document https://learn.microsoft.com/en-us/viva/connections/use-the-link-card#considerations-for-the-navigation-experience.

I will look into teams deeplink navigation in quick view in the upcoming week and update you.

dennisjsyi commented 1 year ago

@Ismael-Cruz @harshdamaniahd I've tested in VCD deep link navigation that is configured to a quick view button. It is opening teams app in VCD and issue does not reproduce. Can you verify?

harshdamaniahd commented 1 year ago

Hi @dennisjsyi , i am trying to open a sharepoint page inside quick view like this ? is this supported ? ..it works in desktop but not in mobile ios. It works on android. on android it asks to install sharepoint and then it works https://teams.microsoft.com/l/stage/2a527703-1f6f-4559-a332-d8a7d288cd88/0?context= {"contentUrl":"https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","websiteUrl":"https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","name":"testn"}

harshdamaniahd commented 1 year ago
  • iOS 14.8.1 + Teams App Version 3.19.0
  • iOS 15.1 + Teams App Version 3.20.0 Do we have a fix here ?
dennisjsyi commented 1 year ago

@harshdamaniahd "Tabs link unfurling and Stage View" scenario should be supported. (https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/tabs-link-unfurling).

Will loop in folks from mobile team to investigate.

harshdamaniahd commented 1 year ago

Thanks

dennisjsyi commented 1 year ago

@harshdamaniahd can you verify that the original issue of the bug is not reproducing?

harshdamaniahd commented 1 year ago

@harshdamaniahd can you verify that the original issue of the bug is not reproducing?

Yes i can confirm that it is working in ios , android, teams desktop, web

dennisjsyi commented 1 year ago

@harshdamaniahd Thanks for confirming.

On a related note, we are tracking https://teams.microsoft.com/l/stage/2a527703-1f6f-4559-a332-d8a7d288cd88/0?context= {"contentUrl":"[https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","websiteUrl":"https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","name":"testn"}](https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx%22,%22websiteUrl%22:%22https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx%22,%22name%22:%22testn%22%7D) deep link issue in IOS.

harshdamaniahd commented 1 year ago

@harshdamaniahd Thanks for confirming.

On a related note, we are tracking https://teams.microsoft.com/l/stage/2a527703-1f6f-4559-a332-d8a7d288cd88/0?context= {"contentUrl":"[https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","websiteUrl":"https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx","name":"testn"}](https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx%22,%22websiteUrl%22:%22https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx%22,%22name%22:%22testn%22%7D) deep link issue in IOS.

I have also tested in mac desktop and web ...and it works. but everytime it asks for to do this i.e download the sharepoint mobile app
image

frags51 commented 1 year ago

@harshdamaniahd , Thanks for reporting the issue. As a workaround for now, would it be possible for you to use direct link to the SharePoint page instead of a stageview deeplink? e.g. just set the URL to https://test.sharepoint.com/teams/f1pilotusers/SitePages/Yo-yo.aspx.

harshdamaniahd commented 1 year ago

then it will open outside teams. in a browser correct?

frags51 commented 1 year ago

@harshdamaniahd From Viva Connections mobile, it will open within Viva Connections mobile app. From teams desktop, it may open in browser outside of teams..

harshdamaniahd commented 1 year ago

@harshdamaniahd From Viva Connections mobile, it will open within Viva Connections mobile app. From teams desktop, it may open in browser outside of teams.. @frags51
Was there anything pushed recently ?

Thanks, it did not work before . But now it works on ios and android.

On ios, there is no back button On Android , there is back button ..but not it doesn't work anymore. Even if we go to a sharepoint page from resources tab...it hangs

In android back button for sharepoint pages was working till last week

frags51 commented 1 year ago

Thanks, it did not work before . But now it works on ios and android.

Ah, good to hear. We were tracking a fix - did you update your Teams app recently? How does it open on iOS - inside the Viva Connections app itself?

Could you please paste screenshot of the About page from Viva Connections > Triple dot menu > About?, from both iOS and Android?

Even if we go to a sharepoint page from resources tab...it hangs

We did not push anything related to this, please let me know if it's consistently happening to you.

harshdamaniahd commented 1 year ago

In ios , it was not working. but now it works. @frags51 MicrosoftTeams-image

so when we open the sharepoint link, it opens.


on android there is some bug I believe.

when we open a sharepoint page either from quick view or from resources tab and that page contains a news webpart then if you click on a news , then the news opens , but you cant go back, the only option is to kill the app

MicrosoftTeams-image (2)

frags51 commented 1 year ago

@harshdamaniahd , I was looking for the about page from inside of Viva Connections, not the one that you pasted. i.e. this page:

image

It is accessible from the triple dot menu or gear icon on the header in Viva Connections app.

harshdamaniahd commented 1 year ago

@harshdamaniahd , I was looking for the about page from inside of Viva Connections, not the one that you pasted. i.e. this page:

image

It is accessible from the triple dot menu or gear icon on the header in Viva Connections app. From ios image

harshdamaniahd commented 1 year ago

@harshdamaniahd , I was looking for the about page from inside of Viva Connections, not the one that you pasted. i.e. this page:

image

It is accessible from the triple dot menu or gear icon on the header in Viva Connections app. From ios image

For android image

frags51 commented 1 year ago

Thanks @harshdamaniahd , please give me sometime to get this checked by the team.

frags51 commented 1 year ago

@harshdamaniahd / @Ismael-Cruz Could you please confirm if you are still facing this issue? I believe it should have been fixed with the latest version of Teams app.

ghost commented 1 year ago

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within the next 7 days of this comment. Please see our wiki for more information: Issue List Labels: Needs Author Feedback & Issue List: No response from the original issue author

ghost commented 1 year ago

Closing issue due to no response from the original author. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: No response from the original issue author