SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.24k stars 1.01k forks source link

Viva connections - The title of the Adaptive card changes the property pane header #7659

Closed Rafaelki closed 2 years ago

Rafaelki commented 2 years ago

What type of issue is this?

Question

What SharePoint development model, framework, SDK or API is this about?

πŸ’₯ SharePoint Framework

Target SharePoint environment

SharePoint Online

What browser(s) / client(s) have you tested

Additional environment details

Issue description

Would it be possible that the header of the property pane of an Adaptive card is fixed to the name that appears in the card picker? similar to what webparts do.

At the moment the property pane header displays the Card title, which is something that can be changed if we expose it as a property.

image In the image above, it should say "[Fresh] alerts" in the property pane header

So I would like that the custom cards behave like the OOTB "Web link" card, where the property pane header shows the name of the card (Web link) and it doesn't change when the Card title is updated image

This way the users know what card did they choose from the card picker.

Thanks!

ghost commented 2 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

micwilson911 commented 2 years ago

Hi Rafaelki,

Thank you for bringing this up! We realized that the default scaffolding was a bit confusing and fixed the scaffolding in newer SPFx releases. An alternative is that you can remove the public get title(): string { ... } method within your {file_name}AdaptiveCardExtension.ts file and this will achieve the behavior that is seen on the Web link component. Hope this helps!

ghost commented 2 years ago

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues