SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.23k stars 992 forks source link

Viva Connections on Microsoft Teams Desktop App - Custom API calls in spfx webparts of home site are not working #8355

Closed Srpatil212 closed 1 year ago

Srpatil212 commented 1 year ago

What type of issue is this?

Question

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Target SharePoint environment

SharePoint Online

What browser(s) / client(s) have you tested

Additional environment details

Windows Desktop App for teams

Issue description

We are experiencing that custom API calls in spfx webparts which are added on sharepoint home site are not resolving in Viva Connections App in Windows Desktop client. Sharepoint list calls in these spfx webparts are working fine and returning response in teams desktop client. These api calls are being made to service endpoints using aadhttp client in spfx webparts.

Same api calls in spfx webparts are working fine when deployed as Personal app and Tab on Teams Desktop app.

Custom api calls in these webparts are working fine in Teams Web version Viva Connections.

These were working till a month back. Issue has been observed recently. Is there any new configuration that needs to be done in viva connections configuration to get these working again.

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

lucabandMSFT commented 1 year ago

hey @Srpatil212 , thanks for reaching out. When you say "Viva Connections App in Windows Desktop Client" you mean "Viva Connections app in Teams Desktop on Windows"? Or something different? IF that is the same thing, can you please explain how did you make it work this part: "Sharepoint list calls in these spfx webparts are working fine and returning response in teams desktop client."? Thanks

Srpatil212 commented 1 year ago

@lucabandMSFT Yes its Viva Connections app in Teams Desktop on Windows and Mac systems.

We did not do anything explicitely to make sharepoint list calls work. But the difference between sharepoint calls and custom API calls is that former is using Sphttpclient (which is working fine) and later is using Aadhttpclient (which is failing).

lucabandMSFT commented 1 year ago

@Srpatil212 , thanks

so.. to be clear on the current situation:

did I recap correctly? If yes, is the code the same for #2 and #3? And what is the error you are experiencing? Last, does reading custom API in an ACE when you access the dashboard in SharePoint Page (browser) works?

Srpatil212 commented 1 year ago

@lucabandMSFT Bullet point 1 and 2 are correct. Regarding point (3): The issue is for both ACEs in dashboard webpart on home site and spfx webparts on sharepoint home site which have custom API calls.

They work fine in viva connections app in teams desktop browser version.

Same code is added for all the cases.

lucabandMSFT commented 1 year ago

@Srpatil212, thanks. What is the error you are experiencing? Would be possible for you to collect an HAR file from the Teams desktop for the scenario that doesn't work?

ghost commented 1 year ago

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within the next 7 days of this comment. Please see our wiki for more information: Issue List Labels: Needs Author Feedback & Issue List: No response from the original issue author

ghost commented 1 year ago

Closing issue due to no response from the original author. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: No response from the original issue author