SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.23k stars 992 forks source link

Viva Connection within Teams hyperlinks to SharePoint double encoding space in 'Shared Documents' #8771

Closed swatmaps closed 1 year ago

swatmaps commented 1 year ago

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

Windows

What browser(s) / client(s) have you tested

Additional environment details

Describe the bug / error

Steps to reproduce

  1. Install Viva Connections into Teams with a set homepage + global navigation enabled
  2. Create a Team and create the associated SharePoint page
  3. Navigate within this window to a team SharePoint page and try to click the default Documents link on the quick access menu
  4. Alternatively make a web part on the Homepage Hub that has a hyperlink pointing to the default Document Library of the created SharePoint and it will give the error
  5. This is also the case when linking to a folder via a share link in the same way - strangely enough linking directly to files works fine

Expected behavior

Clicking these links will produce a request that looks like:

https://<company>.sharepoint.com/sites/<site>/_layouts/15/filebrowser.aspx?app=teamsfile&scenario=portals&fileBrowser={%22sdk%22:%221.0%22,%20%22entry%22:%20{%22sharePoint%22:{%22byPath%22:%20{%22folder%22:%20%22%2Fsites%2F<site>%2FShared%2520Documents%2F<folder>%2F<folder>%2F<folder>%22}}},%20%22leftNav%22:%20{%22preset%22:%22current-site%22}}

and will not render the requested resource due to 404ing on the subsequent list calls - instead giving an error page described above

image

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

nilang-shah commented 1 year ago

We are also having exact same issue!

warren-genpoint commented 1 year ago

Same issue on our tenant and all of our client tenants.

swatmaps commented 1 year ago

This issue has been resolved - would it be possible to request a postmortem update or something on what the issue was so I can disclose it to shareholders @VesaJuvonen

swatmaps commented 1 year ago

actually this has regressed again @VesaJuvonen it was fixed but it's broken again

VesaJuvonen commented 1 year ago

This issue is being actively looked for and should be fixed soon. Sorry for the inconvenience.

AJIXuMuK commented 1 year ago

@swatmaps - I've tried to repro it but can't. I've tested the next scenarios:

please, let me know if I missed any scenario.

swatmaps commented 1 year ago

it was fixed again by the time I got into the office this morning @AJIXuMuK

AJIXuMuK commented 1 year ago

@swatmaps - thank you for the confirmation. We had some roll backs and roll outs a the last two weeks. So this probably was a temporary regression. Please, feel free to reopen the issue if it appears again.

ghost commented 1 year ago

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues