SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.24k stars 1k forks source link

generated `.module.scss.ts` files still use tslint #9020

Open ElPrudi opened 1 year ago

ElPrudi commented 1 year ago

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

πŸ’₯ SharePoint Framework

Developer environment

None

What browser(s) / client(s) have you tested

Additional environment details

Describe the bug / error

.module.scss.ts files seem to be auto generated helper files for scss modules. While the framework already switched from tslint to eslint, these generated files still use /* tslint:disable */. When they exist, my eslint configuration fails.

Steps to reproduce

I really have no idea when exactly they are generated, but this process doesn't matter because it's about the file template syntax. Sometimes they appear when I run a dry tsc compile inside my husky pre-commit hooks

Expected behavior

Eslint should ignore it. This can be done with:

/* eslint-disable */

code
/* eslint-enable */

or

/* eslint-disable <rule> */

code
/* eslint-enable <rule> */
ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

AJIXuMuK commented 1 year ago

@ElPrudi - thank you for reporting this one! We've added a work item in the backlog to address it