SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.25k stars 1.01k forks source link

Loading line item extension from custom cdn behind firewall #9262

Open plamenbotev opened 1 year ago

plamenbotev commented 1 year ago

What type of issue is this?

Question

What SharePoint development model, framework, SDK or API is this about?

πŸ’₯ SharePoint Framework

Target SharePoint environment

SharePoint Online

What browser(s) / client(s) have you tested

Additional environment details

Issue description

Hello,

Is it possible to fail early, when trying to load the js of a line item extension from a custom cdn, that is fire walled? The idea is to not block the list of line items if the asset can not be loaded for some users and only allow the extension to load for certain users, that are white listed? It looks like this was working before, but now the whole list of line items is blocked until the assets are loaded and thus for some users the list is unusable.

Best Regards

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

nick-pape commented 1 year ago

Absolutely, we will take a look at this. The list of items should still be rendered even if an extension fails to load.

Are you doing this on a regular SharePoint list, or is the issue happening elsewhere (e.g. a list Web Part)?

plamenbotev commented 1 year ago

Hi, Thank you for taking a look into this so promptly. I am extending the list in the document library. Let me know if any additional information will be of any help.

Best Regards

ivaylomitrev commented 1 year ago

Hey,

Has this been confirmed as a bug and, if so, would you happen to know what the timelines for fixing it would be?

nick-pape commented 1 year ago

Hi there @ivaylomitrev ,

I thought about this more and think this is by-design behavior. For better or worse, it's a better practice for us to fail to render the list item to give the developer/user some feedback that the list item was not rendered, rather than to fail silently if the list item extension failed to load.

However, there should be some UX for this. Can you share a screenshot of what you are seeing in the list UX when this issue occurs?

plamenbotev commented 1 year ago

Hello @nick-pape and thank you for the feedback. I will attach additionally screenshots. At the moment, the whole list / library is not accessible if there is a line item extension that can not be loaded. I think that if there is a timeout during loading the extension assets, the client and the developer can be notified in a way that will keep the list still usable and the data visible. The user could be additionally notified by flash message for example.

plamenbotev commented 12 months ago

Hello again @nick-pape, Just checking if there is any new information regarding this issue? :)

Best Regards, Plamen

nick-pape commented 11 months ago

Hi there, were you able to attach screenshot? I will file a ticket with PG to address this once we have that.

plamenbotev commented 11 months ago

Hi there @nick-pape. Below is the image of the library with the enabled spfx line extension with firewalled assets: Screenshot 2023-12-01 at 11-44-49 development

As you can see all the items are missing due to the inability for the js file to be loaded.