SharePoint / sp-dev-docs

SharePoint & Viva Connections Developer Documentation
https://docs.microsoft.com/en-us/sharepoint/dev/
Creative Commons Attribution 4.0 International
1.24k stars 1.01k forks source link

The close() method disappeared from quickViewNavigator object of ACEs #9346

Open PaoloPia opened 10 months ago

PaoloPia commented 10 months ago

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

Windows

What browser(s) / client(s) have you tested

Additional environment details

Describe the bug / error

There used to be a method close() in the quickViewNavigator property of ACEs but now I cannot find it anymore. It looks like it was removed from the IQuickViewNavigator interface, even if it is still available in the QuickViewNavigator class. As a temporary workaround, I found that I can cast the quickViewNavigator property to QuickViewNavigator. Here you can see an example of the old code, which used to work and nowadays doesn't work anymore:

this.quickViewNavigator.close();

And here is the workaround:

(<QuickViewNavigator<BaseQuickView<IManageOrdersAdaptiveCardExtensionProps,IManageOrdersAdaptiveCardExtensionState>>>this.quickViewNavigator).close();

However, it seems likes a breaking change that should be addressed and fixed. @VesaJuvonen @AJIXuMuK Thanks.

Steps to reproduce

Create a new ACE with SPFx and try to use the method this.quickViewNavigator.close() inside a QuickView action.

Expected behavior

Being able to use the close() method, which used to be available.

ghost commented 10 months ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.