search

ShareX / ShareX

ShareX is a free and open source program that lets you capture or record any area of your screen and share it with a single press of a key. It also allows uploading images, text or other types of files to many supported destinations you can choose from.
https://getsharex.com
GNU General Public License v3.0
28.28k stars 3.11k forks source link

Support Windows Share #3894

Closed yinyue200 closed 4 years ago

yinyue200 commented 5 years ago

fix #3605

2019-07-18_22-15-51

Abu3safeer commented 5 years ago

is this only working if sharex is installed via windows store? or it will work even using standalone\Steam version?

yinyue200 commented 5 years ago

@Abu3safeer It should be packaged as appx first in order to be working.

Abu3safeer commented 5 years ago

As I know appx is only through windows store, that means I have to uninstall it and use windows store version instead.

yinyue200 commented 5 years ago

@Abu3safeer Yes. Or you can just install a appx file without the Store

Abu3safeer commented 5 years ago

Installing appx file without store requires developer features, I don't prefer to use this way. image

yinyue200 commented 5 years ago

@Abu3safeer Right. But as I know there is no way to support the feature without an appx package.

Abu3safeer commented 5 years ago

No problems, I will wait and see what will happen later.

yinyue200 commented 5 years ago

@Jaex How to make this pr be merged😂

yinyue200 commented 5 years ago

@Jaex Could you review the pull request? Thanks

ImSkully commented 5 years ago

Would love to see this merged soon.

yinyue200 commented 5 years ago

rebased with lateast commits

stale[bot] commented 5 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

yinyue200 commented 5 years ago

@Jaex

stale[bot] commented 5 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

yinyue200 commented 5 years ago

😥

karimcambridge commented 5 years ago

Activity guys, let's get this in!

Vectorsmiracle commented 5 years ago

并非必须是appx应用才能使用windows share，firefox浏览器原生可以通过windows share分享网页。

yinyue200 commented 5 years ago

@Vectorsmiracle I can't find the Share feature in Firefox. Could you show a image to me.

Vectorsmiracle commented 5 years ago

@Vectorsmiracle I can't find the Share feature in Firefox. Could you show a image to me.

firefox共享

yinyue200 commented 5 years ago

@Vectorsmiracle It's not the feature talking in the pull request. The feature in Firefox means share content to other app. But the feature discussing in the pull request is about share content to ShareX

azhe403 commented 5 years ago

up, merge

Vectorsmiracle commented 4 years ago

The app store updated a Microsoft office outlook desktop integration app, the app is to add the desktop outlook to the share menu. 图片

yinyue200 commented 4 years ago

@Jaex @lucario @McoreD @sylveon @Xenthys How do you think of the pr

yinyue200 commented 4 years ago

Now , the operation of uploading files will be invoked after sharing to sharex. Any one want to add an option to allow Sharex to display the captured window?

yinyue200 commented 4 years ago

At present, we have only added the feature which make sharex as an share target. If you want to add the feature to share the content from sharex , please click like on this comment.

yinyue200 commented 4 years ago

Now it support share content from ShareX

yinyue200 commented 4 years ago

批注 2019-07-29 020600

yinyue200 commented 4 years ago

@Jaex @lucario @McoreD @sylveon @Xenthys review the pr, please

sylveon commented 4 years ago

I have no control on whether a PR can be merged or not, please stop pinging me in this conversation.

sylveon commented 4 years ago

Also, for a PR to be merged it needs to at least be buildable - your PR doesn't builds in any configuration but the WindowsStore one.

yinyue200 commented 4 years ago

CI failed again. But it not caused by my code. 😂 firefox_2019-07-29_02-46-46 firefox_2019-07-29_02-46-54

stale[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

azhe403 commented 4 years ago

up up

stale[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

yinyue200 commented 4 years ago

@Jaex please review this pull request. please...😥

sylveon commented 4 years ago

Lack of activity by him in this thread should be pretty indicative that he doesn't wants this PR merged.

Bluscream commented 4 years ago

so the new way of saying no is saying nothing? i don't think that's how it works.

sylveon commented 4 years ago

It's how it always worked in this repo.

On Fri, Oct 25, 2019, 16:56 Bluscream notifications@github.com wrote:

so the new way of saying no is saying nothing? i don't think that's how it works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ShareX/ShareX/pull/3894?email_source=notifications&email_token=ABRELNVXQ2Z6ITEG7ZUOJMLQQNMQDA5CNFSM4GREBPNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJRNYI#issuecomment-546510561, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRELNX5EEPZKTKH7BDODLDQQNMQDANCNFSM4GREBPNA .

Bluscream commented 4 years ago

Reminds me of @torvalds. Another autist

ImSkully commented 4 years ago

The next version of Windows will be released before this gets merged and this will become useless.

stale[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

yinyue200 commented 4 years ago

now I'm tired of constantly updating this never-merged pull request to make it compatible with the latest master. If anyone is interested in continuing this thing, you can contact me for any help.