search

ShareX / ShareX

ShareX is a free and open source program that lets you capture or record any area of your screen and share it with a single press of a key. It also allows uploading images, text or other types of files to many supported destinations you can choose from.
https://getsharex.com
GNU General Public License v3.0
28.29k stars 3.11k forks source link

Apply Dark Theme on/off based on Windows 10 Settings>Personalisation>Colours Setting #4310

Closed OscarVanL closed 4 years ago

OscarVanL commented 4 years ago

Windows 10 now has a system-wide Dark Theme setting, wouldn't it be better to set the default colour theme for ShareX based on this setting instead of defaulting to dark theme? 2019-08-29_12-47-43 image

I'm happy to make a PR if you can point me in the right direction for this change :)

OscarVanL commented 4 years ago

My guess is that UseDarkTheme = true in ShareX/ApplicationConfig.cs needs to be instantiated to be whatever Windows' theme setting is?

Jaex commented 4 years ago

Dark theme > Light theme, hence I prefer it to be default option. Otherwise I would have did what you told.

OscarVanL commented 4 years ago

Isn't that subjective? I prefer a dark theme because I use a 32" monitor and light themes give me eyestrain, but what's most important to me is that my applications are consistent.

Isn't it nicer if the user doesn't have to configure this setting multiple times and it just infers the setting from the Windows setting by default?

przyjacieldawida commented 1 month ago

Hi @Jaex ! Is it possible to make this feature? I use Auto Dark Mode in Windows and its inconsistent when ShareX doesn't follow that rule. It will be a great feature. :)