ShareX / ShareX

ShareX is a free and open source program that lets you capture or record any area of your screen and share it with a single press of a key. It also allows uploading images, text or other types of files to many supported destinations you can choose from.
https://getsharex.com
GNU General Public License v3.0
28.11k stars 3.1k forks source link

(Large) scrolling capture App crashed #7366

Closed WimSubzero closed 2 months ago

WimSubzero commented 2 months ago

Hi,

I tried to capture the folliwing web page : https://www.vkernel.ro/blog/clustering-active-directory-certificate-services-ad-cs

this resluted in System.Runtime.InteropServices.ExternalException (0x80004005): A generic error occurred in GDI+. at System.Drawing.Image.Save(Stream stream, ImageCodecInfo encoder, EncoderParameters encoderParams) at ShareX.HelpersLib.ImageHelpers.SavePNG(Image img, Stream stream, PNGBitDepth bitDepth) at ShareX.TaskHelpers.SaveImageAsStream(Image img, EImageFormat imageFormat, PNGBitDepth pngBitDepth, Int32 jpegQuality, GIFQuality gifQuality) at ShareX.TaskHelpers.PrepareImage(Image img, TaskSettings taskSettings) at ShareX.WorkerTask.DoAfterCaptureJobs() at ShareX.WorkerTask.DoThreadJob() at ShareX.WorkerTask.ThreadDoWork() at ShareX.HelpersLib.ThreadWorker.WorkThread() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart()

ShareX 16.0.1

LOg file entry:

2024-03-28 18:08:06.010 - ShareX starting. 2024-03-28 18:08:06.010 - Version: 16.0.1 2024-03-28 18:08:06.010 - Build: Release 2024-03-28 18:08:06.011 - Command line: "C:\Program Files\ShareX\ShareX.exe" 2024-03-28 18:08:06.011 - Personal path: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX 2024-03-28 18:08:06.012 - Operating system: Windows 10 Pro (64-bit) 2024-03-28 18:08:06.012 - Running as elevated process: False 2024-03-28 18:08:06.231 - ApplicationConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\ApplicationConfig.json 2024-03-28 18:08:07.015 - ApplicationConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\ApplicationConfig.json 2024-03-28 18:08:07.021 - UploadersConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\UploadersConfig.json 2024-03-28 18:08:07.029 - MainForm init started. 2024-03-28 18:08:07.287 - UploadersConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\UploadersConfig.json 2024-03-28 18:08:07.290 - HotkeysConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\HotkeysConfig.json 2024-03-28 18:08:07.617 - HotkeysConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\HotkeysConfig.json 2024-03-28 18:08:07.660 - MainForm init finished. 2024-03-28 18:08:07.866 - Startup time: 1884 ms 2024-03-28 18:08:07.934 - Unable to register hotkey: Ctrl + Print Screen 2024-03-28 18:08:07.934 - Hotkey register failed: Hotkey: Ctrl + Print Screen, Description: Capture region, Job: RectangleRegion 2024-03-28 18:08:07.935 - Hotkey registered: Hotkey: Print Screen, Description: Capture entire screen, Job: PrintScreen 2024-03-28 18:08:07.935 - Unable to register hotkey: Alt + Print Screen 2024-03-28 18:08:07.935 - Hotkey register failed: Hotkey: Alt + Print Screen, Description: Capture active window, Job: ActiveWindow 2024-03-28 18:08:07.935 - Hotkey registered: Hotkey: Shift + Print Screen, Description: Start/Stop screen recording, Job: ScreenRecorder 2024-03-28 18:08:07.936 - Hotkey registered: Hotkey: Ctrl + Shift + Print Screen, Description: Start/Stop screen recording (GIF), Job: ScreenRecorderGIF 2024-03-28 18:08:16.466 - HotkeyManager started. 2024-03-28 18:08:16.468 - WatchFolderManager started. 2024-03-28 18:11:10.821 - Task in queue. Job: Job, Type: Image, Host: 2024-03-28 18:11:10.948 - Task status: Preparing 2024-03-28 18:11:11.966 - Image copied to clipboard. 2024-03-28 18:11:11.997 - Unhandled exception: System.Runtime.InteropServices.ExternalException (0x80004005): A generic error occurred in GDI+. at System.Drawing.Image.Save(Stream stream, ImageCodecInfo encoder, EncoderParameters encoderParams) at ShareX.HelpersLib.ImageHelpers.SavePNG(Image img, Stream stream, PNGBitDepth bitDepth) at ShareX.TaskHelpers.SaveImageAsStream(Image img, EImageFormat imageFormat, PNGBitDepth pngBitDepth, Int32 jpegQuality, GIFQuality gifQuality) at ShareX.TaskHelpers.PrepareImage(Image img, TaskSettings taskSettings) at ShareX.WorkerTask.DoAfterCaptureJobs() at ShareX.WorkerTask.DoThreadJob() at ShareX.WorkerTask.ThreadDoWork() at ShareX.HelpersLib.ThreadWorker.WorkThread() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart()

ShareX 16.0.1 2024-03-28 18:11:22.197 - URL opened: https://github.com/ShareX/ShareX/issues?q=is%3Aissue 2024-03-28 18:13:11.308 - URL opened: https://github.com/ShareX/ShareX/issues?q=is%3Aissue 2024-03-28 18:16:18.806 - File opened: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\Logs\ShareX-Log-2024-03.txt 2024-03-28 18:16:57.347 - ShareX continue. 2024-03-28 18:17:35.775 - ShareX starting. 2024-03-28 18:17:35.775 - Version: 16.0.1 2024-03-28 18:17:35.775 - Build: Release 2024-03-28 18:17:35.776 - Command line: "C:\Program Files\ShareX\ShareX.exe" 2024-03-28 18:17:35.776 - Personal path: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX 2024-03-28 18:17:35.777 - Operating system: Windows 10 Pro (64-bit) 2024-03-28 18:17:35.777 - Running as elevated process: False 2024-03-28 18:17:35.805 - ApplicationConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\ApplicationConfig.json 2024-03-28 18:17:36.273 - ApplicationConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\ApplicationConfig.json 2024-03-28 18:17:36.278 - UploadersConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\UploadersConfig.json 2024-03-28 18:17:36.286 - MainForm init started. 2024-03-28 18:17:36.385 - UploadersConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\UploadersConfig.json 2024-03-28 18:17:36.386 - HotkeysConfig load started: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\HotkeysConfig.json 2024-03-28 18:17:36.496 - HotkeysConfig load finished: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\HotkeysConfig.json 2024-03-28 18:17:36.715 - MainForm init finished. 2024-03-28 18:17:36.903 - Startup time: 1156 ms 2024-03-28 18:17:36.952 - Unable to register hotkey: Ctrl + Print Screen 2024-03-28 18:17:36.953 - Hotkey register failed: Hotkey: Ctrl + Print Screen, Description: Capture region, Job: RectangleRegion 2024-03-28 18:17:36.953 - Hotkey registered: Hotkey: Print Screen, Description: Capture entire screen, Job: PrintScreen 2024-03-28 18:17:36.953 - Unable to register hotkey: Alt + Print Screen 2024-03-28 18:17:36.953 - Hotkey register failed: Hotkey: Alt + Print Screen, Description: Capture active window, Job: ActiveWindow 2024-03-28 18:17:36.953 - Hotkey registered: Hotkey: Shift + Print Screen, Description: Start/Stop screen recording, Job: ScreenRecorder 2024-03-28 18:17:36.953 - Hotkey registered: Hotkey: Ctrl + Shift + Print Screen, Description: Start/Stop screen recording (GIF), Job: ScreenRecorderGIF 2024-03-28 18:17:39.283 - HotkeyManager started. 2024-03-28 18:17:39.284 - WatchFolderManager started. 2024-03-28 18:17:51.227 - Folder opened: C:\Users\WimMintiens\OneDrive - The Key 2 IT\Documents\ShareX\Screenshots\

Jaex commented 2 months ago

Looks like it is not possible to save that large images:

https://stackoverflow.com/questions/41876659/net-saving-very-large-images

GDI+ limits the maximum height of an image to 65500

https://stackoverflow.com/a/5954626/264877

But it must not crash ShareX, so I will fix that.

WimSubzero commented 2 months ago

Jaex,

Not possible with another format like PNG ?

Met vriendelijke groeten, Kind regards, Cordialement,

Wim Mintiens +32 16 792343

The key 2 IT

[https://media.licdn.com/dms/image/D4D22AQElnoImE3saDQ/feedshare-shrink_2048_1536/0/1711534737966?e=2147483647&v=beta&t=dA7qCPeYUhHJYyL0JwxAUT0u9orKeAinYALl4DDLyrU]https://www.linkedin.com/feed/update/urn:li:activity:7178697005827842049 Obserwatorium.biz on LinkedIn: #digitalidentity #europeanunion #qes #eidas #eidas2https://www.linkedin.com/feed/update/urn:li:activity:7178697005827842049 📢 We are excited to invite you to our upcoming online webinar on 👉 eIDAS 2.0 Webinar – A Breakthrough in European Identity and Digital Services Availability.… www.linkedin.comhttp://www.linkedin.com

From: Jaex @.> Sent: Thursday, 28 March 2024 19:08 To: ShareX/ShareX @.> Cc: Wim Mintiens @.>; Author @.> Subject: Re: [ShareX/ShareX] (Large) scrolling capture App crashed (Issue #7366)

Looks like it is not possible to save that large images: https://stackoverflow.com/questions/41876659/net-saving-very-large-images

But it must not crash ShareX, so I will fix that.

— Reply to this email directly, view it on GitHubhttps://github.com/ShareX/ShareX/issues/7366#issuecomment-2025819660, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APM3DLGGTELK26C44AXVISLY2RMADAVCNFSM6AAAAABFNFWWZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVHAYTSNRWGA. You are receiving this because you authored the thread.Message ID: @.**@.>>