search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Error for no renderings available only has mail link, not feedback form #204

Closed jeffbl closed 2 years ago

jeffbl commented 2 years ago

If you have a photo that doesn't return any renderings, it pops up a window that just says something like, "IMAGE can't handle this, please email us to let us know". Since a valid request was made, this should use the same path as the renderings window, and allow the user to mark the request as OK for us to look at, and fill out the feedback form to let us know any other detail.

jeffbl commented 2 years ago

@Cybernide too late for CSUN unless you think absolutely crucial, unfortunately, but I'd argue this should go in shortly after.

jeffbl commented 2 years ago

@hongyec Do you need any further information on this in order to complete it this sprint?

hongyec commented 2 years ago

Hi @jeffbl, just back from vocation. Will take a further look at it today!

hongyec commented 2 years ago

@jeffbl, @jaydeepsingh25 , to confirm I understand it correctly, even if we don't return any rendering, we should have a message containing "We love getting feedback and bug reports using our feedback form.", and have feedback form link appended right?

jeffbl commented 2 years ago

Yes, so that the user has the option of pointing us to the graphic that provided the menu item/button, but did not actually return any rendering. The idea is that they might have expected it to work, and maybe it should work, but there is some glitch in how we're handling things. UI-wise, it should be as close as possible (identical?) to the case where a rendering is actually returned. If any questions on the UI portion, please ping @Cybernide.