Closed jaydeepsingh25 closed 2 years ago
@jeffbl , you can use the following extension build for testing: extension.zip
Loaded above extension in Brave and targeted unicorn. Did not see any issues in brief test of sample map, sample chart (etherscan), or several online photos. Only weirdness is that it sometimes took a very long time for the progress dialog to pop up. Regularly around 3s.
I think this is ready for merge, but I expect this will get a fuller round of testing before our next push to production.
@rayanisran / @sriGanna , can you please perform a round of testing to check if the extension attached above does not introduce any regression for Haptics Renderings?
Thanks to @ryan and @sriGanna to fix the issue for Haptics Renderings. Since all the check above are satisfied, I am merging this PR.
This PR performs extension code refactoring as mentioned in the https://github.com/Shared-Reality-Lab/IMAGE-browser/issues/91. The PR should only be merged if it does not introduce any regression with the existing functionality. A few regression checks on the PR are:
I have performed these basic checks on the PR (except Haptics Rendering), and it does not seem to break anything existing. @jeffbl , Can you please do another check on your end? Not sure, if I missed any other scenario to be checked. In case I missed anything, please feel free to add it to the above checklist.