Brave: Extension developer mode doesn't show Haply options

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code

Other

2 stars 0 forks source link

Brave: Extension developer mode doesn't show Haply options #237

Closed jeffbl closed 1 year ago

jeffbl commented 2 years ago

Still works in Chrome on Linux In Brave on Linux, running latest extension build (https://github.com/Shared-Reality-Lab/IMAGE-server/issues/457) In extension options, turn on developer mode, and see this:

EXPECT: Haply options should appear.

Unless we find similar behavior on another more common browser, not putting this in NFB milestone since Brave users probably few and far between, and only impacts haptics options, which would only impact our own demos at this point.

jaydeepsingh25 commented 2 years ago

I believe this is expected behavior. The functionality was implemented as part of work-item https://github.com/Shared-Reality-Lab/IMAGE-browser/issues/84, and thus the haply option should not come for browsers that do not support Web Serials. Brave and infact Firefox also does not support Web Serial API and hence the option is not visible on these browsers. @jeffbl please let me know if i need to revert this functionality? Otherwise this issue can be closed.

jeffbl commented 2 years ago

And, I think this might even be a dupe, since I got fooled on this before, since I forgot that Brave is different in this respect! Closing.

jeffbl commented 2 years ago

Bringing this back with the idea that it would be better to put in a string in this case, e.g., "Haply 2diy: Unavailable since this browser does not support Web Serial."

jeffbl commented 1 year ago

Given the upcoming focus on haptics in IMAGE, this is likely to be more important. @jaydeepsingh25 Possible to add to option panel refactoring / new functionality milestone?