Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Photo compression by file size only #242

Closed JRegimbal closed 2 years ago

JRegimbal commented 2 years ago

Resolve #238. This removes any compression on the client triggered by an image being more than a certain height or width (1200 pixels previously), since this does not seem to have any benefit. Only size in bytes will result in a request not being handled and all the preprocessors will resize on the server if necessary, which is a far faster process. Resizing because one dimension is 1201 pixels only seems to add time to preparing the request without informing the user, which should be avoided and removed when refactoring is done.

This has been tested with images that do and do not trigger the compression (taken from Wikimedia's large images).

For more discussion, please see #238.

Assigning to @jaydeepsingh25 for client code review and @rohanakut to verify this won't break any preprocessors.