Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

fix latency issue and update error message #250

Closed jaydeepsingh25 closed 2 years ago

jaydeepsingh25 commented 2 years ago

The PR provides a fix for https://github.com/Shared-Reality-Lab/IMAGE-browser/issues/247 and https://github.com/Shared-Reality-Lab/IMAGE-server/issues/468

jaydeepsingh25 commented 2 years ago

Tested on Chromium. I don't see the long polling now, so this should be fine. To check, did you figure out why the array was initialized to be full of junk previously? It should be fine to merge as is in any case.

The issue was because of the way javascript behaves. For eg. if i intialize an empty array, and then just assign a value at some index, then javascript will automatically change the length of that array. image