search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Saving graphic for further processing in feedback system fails #251

Closed jeffbl closed 1 year ago

jeffbl commented 2 years ago

Caught by @Cybernide - good catch!

Go to etherscan.io Tiny chart on right side of page should have a "Get IMAGE rendering" button Click button In popup dialog, check box for "(Optional) I consent to the IMAGE project saving this request and the responses associated with it under the conditions described above." Note: nothing happens: Expect: get form for submitting the graphic for analysis.

Note: If you don't check that box, it works fine.

Cybernide commented 2 years ago

Caught by @Cybernide - good catch!

Yay, I did a thing!

To be very specific, what happened to me was I ran IMAGE on the first photo in the front page

Checking the box gave me a message box with the heading "IMAGE Extension" and a message "An unexpected response was received! Status 404" for which I had to click "OK" to clear. It then took me back to the popup window

jeffbl commented 1 year ago

Seems to work using the extension built from the merge above. However, I don't see the UUID filled in. I submitted a report a few minutes ago. @JRegimbal can you confirm that there is an uploaded entry correctly saved on the server? What makes me nervous is that I don't see the UUID field filled in on the form:

image

jaydeepsingh25 commented 1 year ago

I believe this is expected behavior, the UUID will be filled only when the user checks the consent checkbox, otherwise it remains empty. Atleast this is the way it is implemented in the code. @JRegimbal can you please confirm this?

JRegimbal commented 1 year ago

I didn't implement this, and if I did I forgot :laughing: It is being filled and saved correctly when the user does check the consent box. When not, I don't think we get any benefit from having it filled since we won't be able to see outputs related to that request.

jeffbl commented 1 year ago

@JRegimbal it was more to check that the right thing had happened on the server in the end.

Anyway, I was sure I'd checked the consent box, and still not seen the UUID in the form. But I just tried it again (twice), and it correctly appeared both times. I'll chalk this up to user error unless we see it again...