search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Verify object detection SVG overlay is drawn correctly #280

Closed jeffbl closed 1 year ago

jeffbl commented 1 year ago

Brave on Linux Currently nightly build, debug mode on

Testing on the laptop/coffee cup/phone photo on the IMAGE homepage. Object detection rectangles all look like they are drawn too high on the image. For example, the bounding box for the "cell phone" looks like it might properly enclose the phone if shifted down quite a bit, but doesn't even include any pixels of the phone. I'm logging in browser repo in case it is being drawn incorrectly, but this could also be due to the original overlay being miscalculated? (Or is OD really returning results that are way off?!?)

image

jaydeepsingh25 commented 1 year ago

I believe this is a problem with server side logic. The SVG is properly drawn on the extension UI. @rohanakut , can you please check why the OD results are not correct. I tried it for a few other images as well, and they also have a similar issue. For eg, in the following image, the box for "mouse" is drawn above the actual mouse. image

rohanakut commented 1 year ago

@jeffbl closing this since the PR is merged