search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Include timestamp of build in extension information #286

Closed jeffbl closed 1 year ago

jeffbl commented 1 year ago

Right now, we have a manually incremented version number, but with more focus on test builds going forward, there is a concern about being able to easily identify exactly what build someone is running, so that they can make sure they are up-to-date, and can specify an exact build when logging issues. We had some discussion on this before the break, and my recollection is that we decided a timestamp was the lowest-haning fruit for doing this, but if we need to have a broader discussion about browser extension version numbers and timestamps, happy to do that. Ping to @Cybernide and @JRegimbal since this may impact you as well.

JRegimbal commented 1 year ago

Would the build timestamp only appear in the version tag in manifest.json, or is this appearing elsewhere too (git, menus, etc.)?

Cybernide commented 1 year ago

I think it might be optional in the menus. I feel like I can't speak for the developers on Git.

jaydeepsingh25 commented 1 year ago

I believe it will be better to have actual git version in manifest rather than timestamp. I guess it is doable, need to do some changes in CI/CD pipeline of extension. @jeffbl What do you think would be better - timestamp or git tag (For eg: 0.4.27) in manifest version?

jeffbl commented 1 year ago

git tag sounds like a good idea, since we can reference it directly to a particular version of the code automatically. If easy to do both, even better? The point is that someone should ideally be able to easily divine exactly what version of the code they are running, and how old it is, so that when debugging, we know exactly what was being used, and the user can easily know how up-to-date they are.

jaydeepsingh25 commented 1 year ago

I have done changes to the build pipeline. Nightly version now reflects the git version in manifest file. @jeffbl , i believe it is not possible to put a timestamp in the manifest version as it is not a valid syntax-https://developer.chrome.com/docs/extensions/mv3/manifest/version/

Cybernide commented 1 year ago

Hey this issue is closed, but thanks! This makes updating the extension maybe only a few seconds faster, but a LOT more convenient for me :)