search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Local graphic files not working (again) #296

Closed jeffbl closed 1 year ago

jeffbl commented 1 year ago

Same symptoms as in #278 . Ubuntu Linux 22.04. Loaded test version of browser extension from Chrome store. Drag & drop photo into browser from local filesystem (tested in Chrome and Brave) Right-click photo within browser Get IMAGE rendering Note: nothing happens Expect: rendering returned

jaydeepsingh25 commented 1 year ago

An interesting observation is that it works with the nightly extension . But local files do not work when the same extension build is downloaded from chrome web store. Probably related to some security policy restriction by chrome. May be it better to have an option for users to upload local files. Need to investigate further.

jeffbl commented 1 year ago

@jaydeepsingh25 moving to production issue since this is something we thought we were already providing to end users. Have you determined that the only solution is to have some additional UI for loading the file and sending it? If that is the only solution, we should loop in @Cybernide to get this designed.

jaydeepsingh25 commented 1 year ago

I have investigated the issue and local files only work with the nightly build. Production/Test build from webstore has probably security restrictions which prevent access to local file system. I believe having a separate UI for loading the files is only full proof solution for local files. @Cybernide , can you help with some wireframe designs. Thanks!!

Cybernide commented 1 year ago

This is probably a little late for me to wireframe for this sprint, but next one?

jeffbl commented 1 year ago

Discussed with @Cybernide , and this can be added once #310 is completed and we have a launchpad window from which to trigger this functionality:

@jaydeepsingh25 exact implementation can be discussed if any of the above is difficult. Goal is to re-enable the ability to use local files, lost in the V3 update.

@Cybernide Please revise from discussion this morning, then assign to Jaydeep.

Moving to May08 sprint as new functionality.

Cybernide commented 1 year ago

Hi @jaydeepsingh25 . See #310 for the wireframe along with the Launchpad wireframe. The file picker should just be a system open file dialog. Please let me know if any of this is unclear or if you have trouble with the wireframing tool.